feat(contracts): add hats gatekeeper contracts #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
requested review from
ctrlc03,
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
ctrlc03
reviewed
Feb 13, 2024
ctrlc03
reviewed
Feb 13, 2024
0xmad
changed the title
spengrah
force-pushed
the
hats-gatekeeper
branch
from
f1b0188
to
1dece7e
Compare
ctrlc03
reviewed
Feb 14, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Collabs in public FTW! Thanks for this @spengrah 🤝🏆 |
0xmad
reviewed
Feb 14, 2024
0xmad
approved these changes
Feb 16, 2024
|
@spengrah could you rebase the branch please? |
spengrah
force-pushed
the
hats-gatekeeper
branch
from
7945cb9
to
87ef9bc
Compare
auto-merge was automatically disabled
March 11, 2024 19:43
Head branch was pushed to by a user without write access
spengrah
force-pushed
the
hats-gatekeeper
branch
from
87ef9bc
to
88bb16c
Compare
ctrlc03
force-pushed
the
hats-gatekeeper
branch
3 times, most recently
from
abc8b53
to
65eaaae
Compare
Adds two flavors of Hats Protocol-powered gatekeeper contracts: - `*Single` gates registration to wearers of a single hat - `*Multiple` gates registration to wearers of multiple hats.
Adds new lines in tests per @0xmad suggestion
…suggestion Breaks HatsGatekeepers.sol into multiple files to conform to solhint style guide. Also: - Adds IHats interface - Adds HatsGatekeeperBase abstract contract for common elements
Adds natspec to IHats.sol
Prevents MACI address from being set to the zero address
Applies the following changes as suggested: - MockHatsProtocol inherits from IHats - fixed several natspec typos
Correctly deploy contracts in tests
spengrah
force-pushed
the
hats-gatekeeper
branch
from
65eaaae
to
81880b3
Compare
Adds `tx.wait()` to each test call that doesn't return a value
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 MACI Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two flavors of Hats Protocol-powered gatekeeper contracts:
HatsGatekeeperSinglegates registration to wearers of a single configured hatHatsGatekeeperMultiplegates registration to wearers of multiple configured hatsAdditional Notes
Inspired by this twitter conversation: https://twitter.com/zkMACI/status/1756077090800050674
Related issue(s)
n/a
Confirmation