Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): add hats gatekeeper contracts #1191

Merged
merged 8 commits into from
Mar 18, 2024
Merged

feat(contracts): add hats gatekeeper contracts #1191

merged 8 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. feat(HatsGatekeepers): add Hats gatekeeper contracts 

    Adds two flavors of Hats Protocol-powered gatekeeper contracts:

- `*Single` gates registration to wearers of a single hat
- `*Multiple` gates registration to wearers of multiple hats.
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fd38a5a View commit details
    Browse the repository at this point in the history

  2. style(HatsGatekeepers): add new lines in tests 

    Adds new lines in tests per @0xmad suggestion
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d8cd814 View commit details
    Browse the repository at this point in the history

  3. refactor(HatsGatekeepers): split into one file per contract per @0xmad … 

    …suggestion

Breaks HatsGatekeepers.sol into multiple files to conform to solhint style guide. Also:

- Adds IHats interface
- Adds HatsGatekeeperBase abstract contract for common elements
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a4d1dce View commit details
    Browse the repository at this point in the history

  4. docs(HatsGatekeepers): adds natspec to IHats.sol 

    Adds natspec to IHats.sol
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8793fb3 View commit details
    Browse the repository at this point in the history

  5. feat(HatsGatekeepers): add zero-address check to setMaciInstance() 

    Prevents MACI address from being set to the zero address
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    88c0bdc View commit details
    Browse the repository at this point in the history

  6. fix(contracts): apply small changes suggested by @kittybest 

    Applies the following changes as suggested:
- MockHatsProtocol inherits from IHats
- fixed several natspec typos
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bb429ae View commit details
    Browse the repository at this point in the history

  7. fix(contracts): correctly deploy test contracts 

    Correctly deploy contracts in tests
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    81880b3 View commit details
    Browse the repository at this point in the history

  8. test(HatsGatekeepers): get hardhat forked network ci tests passing 

    Adds `tx.wait()` to each test call that doesn't return a value
    @spengrah
    spengrah committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c04a23e View commit details
    Browse the repository at this point in the history