Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the doc deployment on CI #1697

Closed
ChihChengLiang opened this issue Nov 30, 2023 · 0 comments · Fixed by #1698
Closed

Fix the doc deployment on CI #1697

ChihChengLiang opened this issue Nov 30, 2023 · 0 comments · Fixed by #1698
Labels
good first issue Good for newcomers T-bug Type: bug

Comments

@ChihChengLiang
Copy link
Collaborator

What command(s) is the bug in?

cargo doc --no-deps

Describe the bug

The build script for integration-tests failed because the CI omits the Solidity.

But to build the documentation we shouldn't add Solidity to CI. We should ignore the documentation of integration tests.

We can try cargo doc --no-deps --workspace --exclude integration-tests for that.

https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/7031910543/job/19134517471#step:5:881

error: failed to run custom build command for `integration-tests v0.1.0 (/home/runner/work/zkevm-circuits/zkevm-circuits/integration-tests)`

Caused by:
  process didn't exit successfully: `/home/runner/work/zkevm-circuits/zkevm-circuits/target/debug/build/integration-tests-b8f[882](https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/7031910543/job/19134517471#step:5:883)81a64068ad/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-changed=build.rs

  --- stderr
  Error: FailedToGetSolidity("\"solc\": No such file or directory (os error 2)")

,

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

No response
@ChihChengLiang ChihChengLiang added T-bug Type: bug good first issue Good for newcomers labels Nov 30, 2023
shikharvashistha added a commit to shikharvashistha/zkevm-circuits that referenced this issue Nov 30, 2023
@shikharvashistha
fix: solidity ci bug
09c2639 
This commit fixes privacy-scaling-explorations#1697 - excludes solidty from doc build

Signed-off-by: Shikhar Vashistha <51105234+shikharvashistha@users.noreply.github.com>
@shikharvashistha shikharvashistha mentioned this issue Nov 30, 2023
Merged
1 task
ChihChengLiang pushed a commit that referenced this issue Dec 1, 2023
@shikharvashistha
[FIX]: solidity CI bug (#1698)
e246d4d 
### Description

This commit fixes #1697 - excludes solidty from doc build

### Issue Link 

#1697 

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

### Contents

- Exclude solidty in doc build

### How Has This Been Tested?

Running `cargo doc --no-deps --workspace --exclude integration-tests
`

cc: @ChihChengLiang

Signed-off-by: Shikhar Vashistha <51105234+shikharvashistha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX]: solidity CI bug shikharvashistha/zkevm-circuits
1 participant
@ChihChengLiang