Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement opcode swap1~swap16 #108

Merged
merged 10 commits into from
Oct 21, 2021
Merged

Implement opcode swap1~swap16 #108

merged 10 commits into from
Oct 21, 2021

Conversation

scroll-dev
Copy link
Collaborator

No description provided.

@ChihChengLiang
Copy link
Collaborator

@mask-pp Can we fix the test for this PR?

@DreamWuGit
Copy link
Collaborator

@mask-pp Can we fix the test for this PR?

will update it today!

@github-actions github-actions bot added T-opcode Type: opcode-related and focused PR/Issue crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Oct 14, 2021
DreamWuGit
DreamWuGit reviewed Oct 14, 2021
View reviewed changes
zkevm-circuits/src/evm_circuit/op_execution/swap.rs
@@ -0,0 +1,483 @@
use super::super::{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to spec privacy-scaling-explorations/zkevm-specs#48

@github-actions github-actions bot removed the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Oct 14, 2021
@DreamWuGit DreamWuGit mentioned this pull request Oct 18, 2021
Closed
ChihChengLiang
ChihChengLiang approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zkevm-circuits/src/evm_circuit/op_execution/swap.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Oct 21, 2021
@github-actions github-actions bot removed the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Oct 21, 2021
han0110
han0110 reviewed Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some untested constraint would require to be fixed.

zkevm-circuits/src/evm_circuit/op_execution/swap.rs Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/op_execution/swap.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Oct 21, 2021
@han0110 han0110 merged commit 531d4ef into privacy-scaling-explorations:main Oct 21, 2021
@ChihChengLiang ChihChengLiang mentioned this pull request Oct 21, 2021
Merged
@gaswhat gaswhat deleted the op_swapx branch October 26, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DreamWuGit DreamWuGit DreamWuGit left review comments

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@han0110 han0110 han0110 approved these changes

Assignees
No one assigned
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-opcode Type: opcode-related and focused PR/Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scroll-dev @ChihChengLiang @DreamWuGit @han0110 @mask-pp