Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up github workflows #1537

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Clean up github workflows #1537

merged 1 commit into from
Jul 21, 2023

Conversation

ed255
Copy link
Member

@ed255 ed255 commented Jul 20, 2023 •
edited

Description

  • Remove bitrot task which was building the benchmarks and examples but we don't have any
  • Merge cargo fmt, clippy and doc links into a single job to reduce noise
  • Split heavy tests and light tests into two jobs to parallelize the work
  • Merge all feature tests into a single job to reduce noise.
  • Disable integration tests on pull requests because they are taking a long time currently. Enable them only when the trigger-integration-test label is set, when they are scheduled via cron, or when pushing to main.
  • Times before: 57 minutes
    • Longest: Integration tests: 57 min
    • Second longest: Tests: 28 min
  • Times now: 19 minutes
    • Longest: Light unit tests: 19 min
    • Second longest: Heavy unit tests: 16 min

@github-actions github-actions bot added the CI Issues related to the Continuous Integration mechanisms of the repository. label Jul 20, 2023
@ed255 ed255 force-pushed the feature/clean-gh-workflows branch 9 times, most recently from 120fe72 to a9649b2 Compare July 21, 2023 09:56
ChihChengLiang
ChihChengLiang approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The CI checks look cleaner! The testing time is also improved by not running the integration tests in every PR.

@ed255
Clean up github workflows
e560228 
- Remove bitrot task which was building the benchmarks and examples but we don't have any
- Merge cargo fmt, clippy and doc links into a single job to reduce noise
- Split heavy tests and light tests into two jobs to parallelize the work
- Merge all feature tests into a single job to reduce noise.
- Disable integration tests on pull requests because they are taking a long time currently.  Enable them only when the trigger-integration-test label is set, when they are scheduled via cron, or when pushing to main.
@ed255 ed255 force-pushed the feature/clean-gh-workflows branch from a9649b2 to e560228 Compare July 21, 2023 11:11
@hero78119 hero78119 self-requested a review July 21, 2023 14:05
hero78119
hero78119 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for solving the painful waiting time when PR is submit

@ed255 ed255 added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit 6147354 Jul 21, 2023
11 checks passed
@ed255 ed255 deleted the feature/clean-gh-workflows branch July 21, 2023 14:09
@ChihChengLiang ChihChengLiang mentioned this pull request Sep 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@hero78119 hero78119 hero78119 approved these changes

Assignees
No one assigned
Labels
CI Issues related to the Continuous Integration mechanisms of the repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ed255 @ChihChengLiang @hero78119