Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current codebase uses many patterns that are difficult to reason and debug.
For example,
pattern 1
This requires
b13_chunks
to be in big endianness, but a reader might not be aware of it.Solution: We collect them in the same function
f_from_radix_be
so that we have to reason only once. And from the function name, we know the input must be in big-endian.pattern 2
We do a lot of manual base conversion like
Solution: The
bigUint
has an expressiveto_radix_be
API to allow us to perform base conversion easily.