-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit for opcode SELFBALANCE #328
Circuit for opcode SELFBALANCE #328
Conversation
@scroll-dev Mason Liang Can we do a rebase for this? |
5906508
to
216d31a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, good work!
@z2trillion #292 has been merged! Do you plan on updating this PR to implement the SELFBALANCE in the bus mapping? Or do you prefer doing that in another PR? |
This reverts commit ecc000f.
cb07f2c
to
f3375e0
Compare
@ed255, I've rebased and added the bus mapping. |
@z2trillion There seems to be a linting error coming from clippy. |
522614a
to
9441677
Compare
@ed255 it should be fixed now. |
Implement the SelfbalanceGadget for opcode
SELFBALANCE
.Specs: privacy-scaling-explorations/zkevm-specs#113
Will update the bus mapping for SELFBALANCE once #292 is merged in upstream.