Implement word/next_inputs padding for keccak #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-keccak
CPerezz
force-pushed
the
keccak_padding
branch
from
3917a15
to
e970408
Compare
In order to implement the padding and the full keccak circuit, the circuit for the permutation as well as the gates have been moved to it's own module `permutation` so that everything has a distinct responsability and place.
This gadget constraints the build of a keccak permutation word from 8 bytes constraining the sum and also that all the bytes are in the range [0..255]
Adds tests for the correct and expected error test-cases. This concludes the work on #338
CPerezz
added a commit
that referenced
this pull request
Mar 10, 2022
Adds tests for the correct and expected error test-cases. This concludes the work on #338
CPerezz
changed the title
CPerezz
requested review from
therealyingtong,
ChihChengLiang and
miha-stopar
and removed request for
therealyingtong
ChihChengLiang
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See specs at: https://hackmd.io/zIncjhEuRJioiIbPYfM_DQ
Resolves: #336