Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "state write" to "reversible write" #409

Merged

Conversation

z2trillion
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue labels Mar 25, 2022
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@z2trillion Would you like to update https://github.com/appliedzkp/zkevm-specs and https://github.com/appliedzkp/zkevm-docs/ as well? (they contain several references to state_write_counter)

Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang
Copy link
Collaborator

@z2trillion This PR is mergeable, but it needs a rebase.

@z2trillion z2trillion requested a review from a team as a code owner April 5, 2022 21:33
@z2trillion z2trillion requested review from miha-stopar and removed request for a team April 5, 2022 21:33
@z2trillion
Copy link
Collaborator Author

LGTM!

@z2trillion Would you like to update https://github.com/appliedzkp/zkevm-specs and https://github.com/appliedzkp/zkevm-docs/ as well? (they contain several references to state_write_counter)

Will do

Copy link
Collaborator

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants