Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CONTRIBUTING guidelines to the repo #447

Merged
merged 3 commits into from
Apr 11, 2022
Merged

feat: Add CONTRIBUTING guidelines to the repo #447

merged 3 commits into from
Apr 11, 2022

Conversation

CPerezz
Copy link
Member

@CPerezz CPerezz commented Apr 8, 2022

No description provided.

@CPerezz CPerezz requested a review from a team as a code owner April 8, 2022 16:54
@CPerezz CPerezz requested review from ed255, adria0, barryWhiteHat, ChihChengLiang and han0110 and removed request for a team April 8, 2022 16:54
@CPerezz
Copy link
Member Author

CPerezz commented Apr 8, 2022

Added a review request to all the members that participated in the construction of the guidelines.
Sorry for the noise.

roynalnaruto
roynalnaruto reviewed Apr 11, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
han0110
han0110 reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except some typos, others are clear and look great to me!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
roynalnaruto
roynalnaruto reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have spotted a typo :)

CPerezz and others added 3 commits April 11, 2022 15:54
@CPerezz
feat: Add CONTRIBUTING guidelines to the repo
49c1bc7
@CPerezz @roynalnaruto
Update CONTRIBUTING.md
258dab2 
Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
@CPerezz @han0110
fix: CONTRIBUTING.md title
efc1024 
Co-authored-by: Han <tinghan0110@gmail.com>
ed255
ed255 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@CPerezz CPerezz merged commit f587df2 into main Apr 11, 2022
@CPerezz CPerezz deleted the contributing_guidelines branch April 11, 2022 14:27
@ytrezq
Copy link

ytrezq commented Dec 14, 2022

@barryWhiteHat : Hello, not related would it be possible to ask a few questions about one of your findings somewhere else…

@CPerezz
Copy link
Member Author

CPerezz commented Dec 15, 2022

@barryWhiteHat : Hello, not related would it be possible to ask a few questions about one of your findings somewhere else…

Hey @ytrezq feel free to join the PSE or the zkevm discords. Links: https://discord.gg/jz9ee6XY

@ytrezq
Copy link

ytrezq commented Dec 15, 2022 •
edited

@CPerezz : no I wanted to talk to him about 1 of his groth16 vulnerability findings on Tornado Cash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roynalnaruto roynalnaruto roynalnaruto left review comments

@barryWhiteHat barryWhiteHat barryWhiteHat approved these changes

@han0110 han0110 han0110 approved these changes

@ed255 ed255 ed255 approved these changes

@adria0 adria0 Awaiting requested review from adria0

@ChihChengLiang ChihChengLiang Awaiting requested review from ChihChengLiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CPerezz @ytrezq @roynalnaruto @barryWhiteHat @han0110 @ed255