change: Update sdb/storage-related ops warm check fields #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
CPerezz
force-pushed
the
storageop_field_rename
branch
from
17ca00d
to
c1151e7
Compare
github-actions
bot
added
crate-zkevm-circuits
ed255
reviewed
Apr 12, 2022
CPerezz
force-pushed
the
storageop_field_rename
branch
from
e7cd831
to
d67d2c4
Compare
`TxAccessListAccountOp`, `TxAccessListAccountStorageOp` and `AccountDestructedOp` contain fields called `value` and `value_prev` which basically are `bool`s marking whether the access to these values in the operation are WARM or not. Makes more sense to name them as `is_warm`/`is_warm_prev` (is_destructed/is_destructed_prev` for `AccountDestructedOp`. Resolves: #442
CPerezz
force-pushed
the
storageop_field_rename
branch
from
d67d2c4
to
568f069
Compare
ed255
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxAccessListAccountOp,TxAccessListAccountStorageOpandAccountDestructedOpcontain fields calledvalueandvalue_prevwhich basically are
bools marking whether the access to these values in the operation are WARM or not.Makes more sense to name them as
is_warm/is_warm_prev(is_destructed/is_destructed_prev for
AccountDestructedOp.Resolves: #442