-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate gadgets from zkevm-circuits mod to it'w own crate #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a good idea to me! It seems all ok to me!
/// +----+-------+-----------+-----------------------+---------------------------------+-------------------------------------+ | ||
/// | ok | value | value_inv | 1 - value ⋅ value_inv | value ⋅ (1 - value ⋅ | ||
/// value_inv) | value_inv ⋅ (1 - value ⋅ value_inv) | | ||
/// +----+-------+-----------+-----------------------+---------------------------------+-------------------------------------+ | ||
/// | V | 0 | 0 | 1 | 0 | ||
/// | 0 | | | 0 | x | 1 | ||
/// | 0 | x | | ||
/// | | x | 0 | 1 | x | ||
/// | 0 | | V | x | 1/x | 0 | ||
/// | 0 | 0 | | ||
/// | | x | y | 1 - xy | x(1 - xy) | ||
/// | y(1 - xy) | | ||
/// +----+-------+-----------+-----------------------+---------------------------------+-------------------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CPerezz the formatting seems broken here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh damn!!!
Let me make a quick fix PR
Resolves: #444