Implementation of tx circuit (shortcut 1) #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
github-actions
bot
added
the
CI
ed255
force-pushed
the
feature/tx-circuit
branch
3 times, most recently
from
5042e3c
to
914c2bd
Compare
ed255
changed the title
CPerezz
reviewed
May 18, 2022
Comment on lines
+32
to
+36
| ecdsa = { git = "https://github.com/appliedzkp/halo2wrong", rev = "92b96893b5699ff40723e201a2416313aeafd267", features = ["kzg"] } | ||
| secp256k1 = { git = "https://github.com/appliedzkp/halo2wrong", rev = "92b96893b5699ff40723e201a2416313aeafd267", features = ["kzg"] } | ||
| ecc = { git = "https://github.com/appliedzkp/halo2wrong", rev = "92b96893b5699ff40723e201a2416313aeafd267", features = ["kzg"] } | ||
| maingate = { git = "https://github.com/appliedzkp/halo2wrong", rev = "92b96893b5699ff40723e201a2416313aeafd267", features = ["kzg"] } | ||
| integer = { git = "https://github.com/appliedzkp/halo2wrong", rev = "92b96893b5699ff40723e201a2416313aeafd267", features = ["kzg"] } |
There was a problem hiding this comment.
We should release a tag as we do for halo2_proofs. Otherways this might be hard to track in the future.
github-actions
bot
added
the
crate-eth-types
5 tasks
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 24, 2022
adria0
reviewed
May 25, 2022
adria0
reviewed
May 25, 2022
adria0
reviewed
May 25, 2022
adria0
reviewed
May 25, 2022
adria0
reviewed
May 25, 2022
| // by keccak table lookup, where pub_key_bytes is built from the pub_key | ||
| // in the ecdsa_chip | ||
| // keccak lookup | ||
| meta.lookup_any("keccak", |meta| { |
There was a problem hiding this comment.
Just thinking out loud to @CPerezz. Wondering what interface can we add to keccak config to simplify this gate.
There was a problem hiding this comment.
I thought the same! ahhahah
That's why I wanted to meet with you. Since we can do a proxy-table to simplify the API (at a cost obviously). And I thought that once the state_tag stuff is handled (I'm working on it), We should meet with @miha-stopar and @ed255 to see what are they expecting exactly as API.
adria0
reviewed
May 26, 2022
Implement the Tx Circuit as specified in https://github.com/appliedzkp/zkevm-specs/blob/master/specs/transactions-proof.md#circuit-behaviour-shortcut-1 This implementation uses ~205 columns and ~170k rows per transaction. New dependencies to the zkevm-circuits subcrate: - `halo2wrong` subcrates. This is where the ECDSA verification chip is implemented. This dependency uses `halo2` and this means that we'll require the version of `halo2` used in `halo2wrong` and `zkevm-circuits` to match. - `group`: Required for field and curve traits - `libsecp256k1`: Requiered to perform the ECDSA public key recovery with access to the public key coordinates. - `rlp`: Required to calculate the RLP of the transaction to get the transaction hash (to sign) - `num-bigint`: Used to hold an integer bigger than the field, to latter apply mod Fq (this is required for the message hash in the ECDSA signature operation) - `subtle`: Used to map `CtOption` to `Result`
adria0
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the Transaction Circuit as specified in https://github.com/appliedzkp/zkevm-specs/blob/master/specs/transactions-proof.md#circuit-behaviour-shortcut-1
Depends on:
New dependencies to the zkevm-circuits subcrate:
halo2wrongsubcrates. This is where the ECDSA verification chip is implemented. This dependency useshalo2and this means that we'll require the version ofhalo2used inhalo2wrongandzkevm-circuitsto match.group: Required for field and curve traitslibsecp256k1: Requiered to perform the ECDSA public key recovery with access to the public key coordinates.rlp: Required to calculate the RLP of the transaction to get the transaction hash (to sign)num-bigint: Used to hold an integer bigger than the field, to latter apply mod Fq (this is required for the message hash in the ECDSA signature operation)subtle: Used to mapCtOptiontoResultThe added tests for tx_circuit use
k=19, which use a lot of memory even using the MockProver. Rust tests run in parallel by default, which may make the tests run out of memory when the tx_circuit tests are run concurrently with other tests. For this reason I've split the tests into "light" (which are all the test declared previously), and "heavy" which are marked with ignore and start with "serial_" and are run in a different step in serial both in the github actions and Makefile.Notes on current implementation: