Opcode SHR
#519
Merged
Opcode SHR
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
github-actions
bot
added
the
crate-zkevm-circuits
|
Reviewing this now. Sorry for the delay. |
Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
with `shr_gadget_rand_normal_shift`.
|
Sorry, will defer my review to @miha-stopar. Was too busy working on other stuff. |
ChihChengLiang
requested review from
miha-stopar
and removed request for
ChihChengLiang
miha-stopar
approved these changes
Jun 2, 2022
davidnevadoc
pushed a commit
to davidnevadoc/zkevm-circuits
that referenced
this pull request
Jun 8, 2022
* Add `SHR` circuit. * Add `ShrWordsGadget` to `math_gadget.rs`. * Add more contraints. * Update. * Fix lint. * Fix. * Fix to convert `shf_div64` to u64 when calling assign. Co-authored-by: Haichen Shen <shenhaichen@gmail.com> * Fix to convert `shf_mod64` to u64 when calling assign. Co-authored-by: Haichen Shen <shenhaichen@gmail.com> * Delete useless local variables `shf_div64` and `shf_mod64`. * Fix to add `cb.require_equal` when contructing `a64s_lo_lt_p_lo`. * Shorten `b64s[0]` constraint name. Co-authored-by: Haichen Shen <shenhaichen@gmail.com> * Shorten other `b64s[idx]` constraint names. * Add more test cases. * Fixed to use `rand_word()` in cases of `shr_gadget_simple` and merged with `shr_gadget_rand_normal_shift`. * Add more comments according to code review. * minor tweak Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
lispc
pushed a commit
that referenced
this pull request
Jun 1, 2023
* expose keccak circuit APIs * expose more fields * [chore] fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: privacy-scaling-explorations/zkevm-specs#195