Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small mixing fix #577

Merged
merged 1 commit into from
Jun 20, 2022
Merged

small mixing fix #577

merged 1 commit into from
Jun 20, 2022

Conversation

ChihChengLiang
Copy link
Collaborator

assign_out_mixing_states already created the merged state. Returned it directly is the correct implementation.

@github-actions github-actions bot added the crate-keccak Issues related to the keccak workspace member label Jun 16, 2022
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said the other day, really good catch! At some point I think git re-introduced this or something as it was fixed for some time already.

Thanks a lot @ChihChengLiang

@ChihChengLiang ChihChengLiang merged commit 4d54891 into main Jun 20, 2022
@ChihChengLiang ChihChengLiang deleted the small-mixing-fix branch June 20, 2022 10:43
ChihChengLiang added a commit that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate-keccak Issues related to the keccak workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants