Externalize Circuit-related logic to zkevm-circuits #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPerezz
added
crate-bus-mapping
CPerezz
force-pushed
the
circuit-stuff-removal
branch
from
07e374f
to
bda49bb
Compare
han0110
approved these changes
Sep 1, 2021
jingyu123412
referenced
this pull request
in scroll-tech/zkevm-circuits
Nov 4, 2021
* add add and sub opcode * use is_sub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @han0110 we should externalize all of
the Constraint-System/circuit related stuff to zkevm-circuits
in order to reduce circular depency issuesand make
the overall solution simpler.
Resolves: #49