Keccak test cases #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChihChengLiang
force-pushed
the
keccak-test-cases
branch
2 times, most recently
from
4c4de4b
to
9ce3b78
Compare
ChihChengLiang
force-pushed
the
keccak-test-cases
branch
3 times, most recently
from
01d9cdd
to
ae56d43
Compare
ChihChengLiang
force-pushed
the
keccak-test-cases
branch
from
637f842
to
a4bfe62
Compare
ChihChengLiang
force-pushed
the
keccak-test-cases
branch
from
a4bfe62
to
2219fce
Compare
github-actions
bot
added
the
crate-keccak
ChihChengLiang
force-pushed
the
keccak-test-cases
branch
from
43e22c6
to
aaf6d31
Compare
CPerezz
approved these changes
Oct 5, 2021
|
|
||
| pub const PERMUTATION: usize = 24; | ||
|
|
||
| pub static ROUND_CONSTANTS: [u64; PERMUTATION] = [ |
There was a problem hiding this comment.
Can we add a link to the place where we extracted the constants from?
There was a problem hiding this comment.
I've added links to where the constants are from.
|
Merged to unblock upcoming works. Feel free to give post merging review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need some intermediate values between keccak steps to build test cases.
Solution
Modify https://github.com/Follow-DeFi/keccak-rust to get a version of arithmetic keccak.
TODO