Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Spec for opcode RETURNDATACOPY #274

Merged
merged 23 commits into from
Oct 24, 2022
Merged

Spec for opcode RETURNDATACOPY #274

merged 23 commits into from
Oct 24, 2022

Conversation

smtmfft
Copy link
Contributor

@smtmfft smtmfft commented Sep 15, 2022

No description provided.

smtmfft and others added 18 commits August 31, 2022 13:04
@smtmfft
add return data copy op code spec
acb3753 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix the single test case
b9fe2d0 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix 3eRETURNDATACOPY.md description
76f3219 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
use callee id as copy src_id
9aa1314 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
add more testcases and fix memory expension gas calculation
15b3258 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix typo
ebbb537 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix typo
ea2aa62 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix review comments
bebe12b 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
use call_id as src_id of the copy table
801f184 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft @Brechtpd
Update specs/opcode/3eRETURNDATACOPY.md
cbfd13f 
update spec

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
@smtmfft
fix review comments
2dd4e27 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
add more description of evm behaviour
84a150f 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
no need to read callee_id
6f7f7cc 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix descrpiton and some numbers
60a3114 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
change few words
e1bd224 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
code clean
6285a61 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
change circuit behaviour desc
087e208 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix lint check
92d3524 
Signed-off-by: smtmfft <smtm@taiko.xyz>
This was referenced Sep 19, 2022
Merged
Closed
@han0110 han0110 self-requested a review September 22, 2022 09:02
han0110
han0110 reviewed Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some missing checks, otherwise it looks good!

src/zkevm_specs/evm/execution/returndatacopy.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm/execution/returndatacopy.py Show resolved Hide resolved
tests/evm/test_returndatacopy.py Outdated Show resolved Hide resolved
@smtmfft
add missed copy boundary check
26c049f 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
tiny fix
4b32d3b 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix review comments
6a68a6f 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix rw_counter
483dbee 
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft
fix opcode description
06093bf 
Signed-off-by: smtmfft <smtm@taiko.xyz>
han0110
han0110 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@adria0
Copy link
Member

adria0 commented Oct 11, 2022

LGTM! :)

@ChihChengLiang
Copy link
Collaborator

Merge for getting two approvals.

@ChihChengLiang ChihChengLiang merged commit babd33e into privacy-scaling-explorations:master Oct 24, 2022
@Brechtpd Brechtpd mentioned this pull request Jan 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adria0 adria0 adria0 approved these changes

@han0110 han0110 han0110 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smtmfft @adria0 @ChihChengLiang @han0110