[WIP] Follow EIP1559 to calculate correct transaction gas price
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
force-pushed
the
feature/support-eip1559
branch
from
2806b97
to
092e492
Compare
han0110
force-pushed
the
feature/support-eip1559
branch
from
a6a940d
to
67f54e9
Compare
|
Close in favor of #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the missing block constant functionality of
Instructionand implementEIP1559onBeginTx.Currently the block constant can be used directly, just like using the copy constraint in halo2. But the opcode
BLOCKHASHrequires to access up to previous 256 block hashes, which would be expensive to copy 256 value at each step. See more discussion on #75.