Add block_lookup in Instruction for block constant access
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
changed the title
Block in Instruction for block constant accessBlock in Instruction for block constant access
This was referenced Dec 10, 2021
han0110
force-pushed
the
feature/block-constant
branch
from
fb5c31c
to
8994742
Compare
han0110
changed the title
Block in Instruction for block constant accessblock_context_lookup in Instruction for block constant access
han0110
changed the title
block_context_lookup in Instruction for block constant accessblock_lookup in Instruction for block constant access
DreamWuGit
reviewed
Dec 21, 2021
DreamWuGit
reviewed
Dec 21, 2021
han0110
force-pushed
the
feature/block-constant
branch
2 times, most recently
from
8f882fe
to
a35af4a
Compare
han0110
force-pushed
the
feature/block-constant
branch
from
a35af4a
to
e2dbd08
Compare
|
Could we merge this first? We have a |
ChihChengLiang
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the missing block constant functionality of
Instruction.It adds a
block_tableto store all static block constant and up to previous 256 block hashes for block constant lookup. The table in real implementation could share the same instance columns withtx_tableonce they are properly separate by selectors.This approach targets a straightforward implementation, in the future we could also adopt
EIP2935mentioned in #75 to totally removeblock_table.