Identify MV3 errors post-merge

[OliverWang13]

I am opening this issue as a place for us to report bugs we find after the big MV3 merge, and then we can open new issues to tackle big bugs or can do quick fixes for smaller bugs. Bugs should be reported in a checklist and then checked off when dealt with.

[OliverWang13]

First two things I noticed:

• The popup tutorial button does not work consistently
• The enable/disable popup functionality has stopped working as well

[OliverWang13]

Note about the popup tutorial button, in the issue-288 branch it seems to work fine on Firefox, it likely is messed up due to how Mv3 handles listeners? The main issue is when you are on the settings page and hit the tutorial button it does not pop up, but it does change TUTORIAL_SHOWN to false so the next time you navigate to the page the tutorial is shown

[OliverWang13]

As @SebastianZimmeck brought up, there is an issue with the optmeowt popup icon changing when on a site with the well-known file

[SebastianZimmeck]

The icon does not change at all; not on sites with .well/known but it also does not have the brief green glow around the edges when sending a GPC signal.

[SebastianZimmeck]

Also, here are various error messages:

[OliverWang13]

I am finding that the "domains receiving signals" does not seem to be working for me, and I will create a new working list of the bugs that we know of.

[OliverWang13]

• tutorial button not working
• popup symbol not changing
• domains receiving signals not working

[OliverWang13]

I fixed two of the issues, the only outstanding one I know of is

• popup symbol not changing

[OliverWang13]

From what I can tell, analysis mode on firefox seems like it may have stopped functioning? In theory it shouldn't have any issues because I don't think Kuba messed with that code, but I will look into it further.

[OliverWang13]

I will be creating a checklist of OptMeowt features that we want to make sure are working.

[OliverWang13]

Below is a rudimentary checklist of things to verify concerning the functionality of optmeowt.
Chrome:

• From settings page:
• Domain List button works
• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)
• Domains can be toggled on/off
• About button works
• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)
• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)
• Disable settings works (reflected in popup, visit site and see if the signal is sent)
• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?
• Export domain list works
• Import domain list works
• From popup:
• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit big site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Firefox:

• From settings page:
• Domain List button works
• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)
• Domains can be toggled on/off
• About button works
• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)
• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)
• Disable settings works (reflected in popup, visit site and see if the signal is sent)
• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?
• Export domain list works
• Import domain list works
• From popup:
• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit big site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page
• Analysis:
• Change to analysis mode, clear cookies
• Navigate to site (preferably one that respects GPC, like nba.com)
• Collect ground truth based on methodology outlined in our data spreadsheet
• Run analysis based on methodology outlined in our data spreadsheet
• Compare the two, they should be the same

[OliverWang13]

Useful snippets:
__uspapi('getUSPData', 1, (data) => { console.log("USP Data: ", data); });
navigator.globalPrivacyControl

[SebastianZimmeck]

As just discussed, once @OliverWang13 gives the OK that we are ready to test, everyone again goes through the checklist above that @OliverWang13 and @sophieeng created. Please make a checkmark if all tests were successful.

• @OliverWang13 confirms everything is working
• @sophieeng confirms everything is working
• @Jocelyn0830 confirms everything is working

It would also be good, @OliverWang13 and/or @sophieeng, if you could set up a meeting (or clarify otherwise) with @Jocelyn0830 to make sure @Jocelyn0830 can run the latest version of the code.

On a side note, I am seeing now that some of the checkboxes in the checklist above are not set. Let's make sure we test comprehensively.

[OliverWang13]

FOR @OliverWang13 CHECKLIST

Chrome:

From settings page:

• Domain List button works

• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)

• Domains can be toggled on/off

• About button works

• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)

• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)

• Disable settings works (reflected in popup, visit site and see if the signal is sent)

• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?

• Export domain list works

• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit big site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Firefox:

From settings page:

• Domain List button works
• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)
• Domains can be toggled on/off
• About button works
• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)
• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)
• Disable settings works (reflected in popup, visit site and see if the signal is sent)
• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?
• Export domain list works
• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit test server site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Analysis:

• Change to analysis mode, clear cookies
• Navigate to site (preferably one that respects GPC and we already know the ground truth for, like nba.com)
• Run analysis based on methodology outlined in our data spreadsheet
• Compare the two, they should be the same

[OliverWang13]

FOR @sophieeng CHECKLIST

Chrome:

From settings page:

• Domain List button works

• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)

• Domains can be toggled on/off

• Domains can be deleted from the list (turn off test server, delete from list, revisit test server. It should be positive)

• About button works

• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)

• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)

• Disable settings works (reflected in popup, visit site and see if the signal is sent)

• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?

• Export domain list works

• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit big site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Firefox:

From settings page:

• Domain List button works
• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)
• Domains can be toggled on/off
• About button works
• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)
• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)
• Disable settings works (reflected in popup, visit site and see if the signal is sent)
• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?
• Export domain list works
• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit test server site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Analysis:

• Change to analysis mode, clear cookies
• Navigate to site (preferably one that respects GPC and we already know the ground truth for, like nba.com)
• Run analysis based on methodology outlined in our data spreadsheet
• Compare the two, they should be the same

[OliverWang13]

FOR @Jocelyn0830 CHECKLIST

Chrome:

From settings page:

• Domain List button works

• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)

• Domains can be toggled on/off

• Domains can be deleted from the list (turn off test server, delete from list, revisit test server. It should be positive)

• About button works

• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)

• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)

• Disable settings works (reflected in popup, visit site and see if the signal is sent)

• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?

• Export domain list works

• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit big site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Firefox:

From settings page:

• Domain List button works
• Domain list build properly (no visual issues, visit a new site and see if it pops up next time you visit domainlist)
• Domains can be toggled on/off
• About button works
• Enable setting works (reflected in popup, visit site and see if headers and dom are sent)
• Domain list setting works (turning a site off from domain list stops the signals - turn a site off and check)
• Disable settings works (reflected in popup, visit site and see if the signal is sent)
• For the different settings, choose a setting then navigate off of the page and reopen it, has the setting stayed the same?
• Export domain list works
• Import domain list works

From popup:

• Disable, enable button works visually
• Disable, enable button effectively sends or doesn't send signals
• More button brings you back to settings page
• Help button opens tutorial
• Help button while options page is open opens tutorial
• Toggle send signal on and off, check if it is reflected on the site when you reload it
• Toggle send signal on and off, check if it is reflected in the domainlist
• Visit test server site and check for 3rd party domains
• Test toggling on and off these 3rd party domains, check domainlist
• Check site that has the well-known property (https://global-privacy-control.glitch.me/, for example), make sure the well-known tab works
• Domain list popup button works
• Toggle darkmode, make sure it is consistent on the settings page

Analysis:

• Change to analysis mode, clear cookies
• Navigate to site (preferably one that respects GPC and we already know the ground truth for, like nba.com)
• Run analysis based on methodology outlined in our data spreadsheet
• Compare the two, they should be the same

[OliverWang13]

This should be resolved, so I will close it