Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Website Response" dropdown on Popup #311

Closed
sophieeng opened this issue Jul 8, 2022 · 2 comments
Closed

Fix "Website Response" dropdown on Popup #311

sophieeng opened this issue Jul 8, 2022 · 2 comments
Assignees
@OliverWang13 @sophieeng
Labels
bug Something isn't working mv3 An issue related to moving from Chrome manifest v2 to v3
Milestone
Finalize release ...

Comments

@sophieeng
Copy link
Collaborator

In the popup, there is a dropdown that says "Website response". This dropdown should say whether or not the .well-known is present but is currently blank no matter if it is present or not.

This was found in going through the checklist in #289 for Chrome.
@sophieeng sophieeng added bug Something isn't working mv3 An issue related to moving from Chrome manifest v2 to v3 labels Jul 8, 2022
@OliverWang13
Copy link
Collaborator

The problem here is that our wellknown object was a global variable that can no longer function in mv3. We just need to find a way to get wellknown[tabId] to dataToPopup().

OliverWang13 added a commit that referenced this issue Jul 9, 2022
@OliverWang13
Fixed well-known popup issue (Issue #311)
af16aad
OliverWang13 added a commit that referenced this issue Jul 9, 2022
@OliverWang13
Merge pull request #321 from privacy-tech-lab/issue-311
9dbaf04 
Fixed well-known popup issue (Issue #311)
@OliverWang13
Copy link
Collaborator

This has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OliverWang13 OliverWang13

@sophieeng sophieeng

Labels
bug Something isn't working mv3 An issue related to moving from Chrome manifest v2 to v3
Projects
None yet
Milestone
Finalize release v.3.0.0 (aka "Kuba's...
Development

No branches or pull requests
2 participants
@OliverWang13 @sophieeng