Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clearer header field name or value #27

Closed
brodrigu opened this issue Feb 8, 2022 · 3 comments
Closed

Use clearer header field name or value #27

brodrigu opened this issue Feb 8, 2022 · 3 comments
Assignees

Comments

@brodrigu
Copy link

brodrigu commented Feb 8, 2022

As designed, I had to review the spec to understand thatSec-GPC: 1 means "do not sell or share".

The Sec-GPC would be more human readable if its name or value suggested the users specific preference.

Two quick suggestions:
Sec-GPC: no-sell-share
Sec-GPC-No-Sell-Share: 1

@SebastianZimmeck
Copy link
Member

I agree, @brodrigu, readability is important. Though, my preference would be to leave the values as they are. For binary values 1 usually means on. Also, other standards have similar notation, especially, DNT = 1 is pretty similar to our use case.

@brodrigu
Copy link
Author

DNT stood for Do Not Track which made it intuitive that when DNT=1 (assuming you knew what DNT stood for) the request was to not be tracked.

With Sec-GCP = 1 if you know GCP stands for Global Privacy Control suggests there is some request for control, but control does not inherently mean "do not sell / share".

I agree that keeping the value 1 makes sense, and if that is the priority then I suppose the ask is to adjust the header name to be more readable.

@pes10k
Copy link
Contributor

pes10k commented Feb 10, 2022

I don't think we should change the header name. This is ultimately an implementation detail, and as long as the meaning is clear and can be looked up by a curious party easily, i dont think we need a full english description sent in every HTTP request. Or in other words, i don't think GPC needs to run in debug mode ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants