-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add option to add {googleurl_img} as an email attachement #1226
Comments
We would have to add another parameter like We would need an email config in the notification handler, to define if images should be sent inline or as attachment. https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/eventhandler/usernotification.py#L113 Here (https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/eventhandler/usernotification.py#L281) we would need to read this config and call |
Here is the explanation how this can be done for outlook. |
It seems, google does not allow inline data URLs in gmail: https://stackoverflow.com/a/42014708/7036742 |
I am looking forward to your pull request ;-) |
Some email programs and providers have problems with inline images or data-URLs so this will be fixed with this commit. The UserNotificationHandler gets an additional option 'attachment' which triggers the creation of a multipart email (text and image) and pass it to the smtp-server. Working on #1226 TODO: Documentation
Using attachments was enforcing an HTML body, this is now fixed. Working on #1226
Documentation is done, so i'll close this. |
Some email programs and providers have problems with inline images or data-URLs so this will be fixed with this commit. The UserNotificationHandler gets an additional option 'attachment' which triggers the creation of a multipart email (text and image) and pass it to the smtp-server. Working on privacyidea#1226 TODO: Documentation
Using attachments was enforcing an HTML body, this is now fixed. Working on privacyidea#1226
Also updated some of the usernotification documentation. Working on privacyidea#1967 Working on privacyidea#1226
Outlook does not support inline images encoded in base64. This is the current method used for QR code in email {googleurl_img} and usernotifcation. Please consider adding the option to include the QR image as an attachment. Another option may be to use the CID or link to the img (if linking, then img/link should expire)
quick link that goes over CID tags
https://sendgrid.com/blog/embedding-images-emails-facts/
The text was updated successfully, but these errors were encountered: