Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add option to add {googleurl_img} as an email attachement #1226

Closed
speedy01 opened this issue Sep 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@speedy01
Copy link

commented Sep 6, 2018

Outlook does not support inline images encoded in base64. This is the current method used for QR code in email {googleurl_img} and usernotifcation. Please consider adding the option to include the QR image as an attachment. Another option may be to use the CID or link to the img (if linking, then img/link should expire)

quick link that goes over CID tags
https://sendgrid.com/blog/embedding-images-emails-facts/

@cornelinux

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

We would have to add another parameter like attachments (being a list) to this function
https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/smtpserver.py#L130

We would need an email config in the notification handler, to define if images should be sent inline or as attachment. https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/eventhandler/usernotification.py#L113

Here (https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/eventhandler/usernotification.py#L281) we would need to read this config and call send_email_identifier (https://github.com/privacyidea/privacyidea/blob/master/privacyidea/lib/eventhandler/usernotification.py#L334) accordingly.

@cornelinux cornelinux added this to the 3.1 New Feature Release milestone Nov 30, 2018

@cornelinux

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Here is the explanation how this can be done for outlook.
https://community.privacyidea.org/t/qr-code-via-sms-or-email/793/9

@cornelinux cornelinux closed this May 16, 2019

@cornelinux cornelinux removed this from the 3.1 New Feature Release milestone May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.