Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove password hash calculation and switch to passlib completely #1372

Closed
plettich opened this issue Jan 11, 2019 · 0 comments
Closed

remove password hash calculation and switch to passlib completely #1372

plettich opened this issue Jan 11, 2019 · 0 comments
Assignees
@plettich
Labels
Topic: Resolver Issues concerning user resolver (SQL, LDAP, ...)
Milestone
3.0 Code Cleanup

Comments

@plettich
Copy link
Member

Currently there are several password hashes supported in the SQLIdResolver which are more or less generated/verified with homegrown code.
We can remove most of the stuff and switch to passlib (which is already used in some cases).
Some hashes (drupal, SSHA512 and SSHA256) are currently not available in passlib but can be added.
@plettich plettich added this to the 3.0 Code Cleanup milestone Jan 11, 2019
@plettich plettich self-assigned this Jan 11, 2019
@cornelinux cornelinux added Topic: Resolver Issues concerning user resolver (SQL, LDAP, ...) and removed infrastructure and config labels Jan 13, 2019
plettich added a commit that referenced this issue Jan 14, 2019
@plettich
Remove password hash calculation
1da7a6d 
To simplify the code the password hash calculation (used in the
SQLIdResolver) is removed and replaced with the passlib module.
Unfortunately passlib does not provide all necessary password hashes, so
these are implemented as passlib handlers.

Fixes #1372
@plettich plettich mentioned this issue Jan 14, 2019
Merged
cornelinux pushed a commit that referenced this issue Jan 17, 2019
@plettich @cornelinux
Remove password hash calculation (#1374)
d461685 
Use passlib for password hashes to streamline code

* Remove password hash calculation

   To simplify the code the password hash calculation (used in the
   SQLIdResolver) is removed and replaced with the passlib module.
   Unfortunately passlib does not provide all necessary password hashes, so
   these are implemented as passlib handlers.

* Fix documentation

   Improve coverage by ignoring unused functionality

* Add check for unknown hash type

   Also check if adding/updating a user with an unknown hash type throws an
   exception.

Fixes #1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plettich plettich

Labels
Topic: Resolver Issues concerning user resolver (SQL, LDAP, ...)
Projects
None yet
Milestone
3.0 Code Cleanup
Development

No branches or pull requests
2 participants
@cornelinux @plettich