Add /system/names/{caconnector,radius} endpoints #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 14, 2019 12:01
These endpoints can be accessed by users and admins to retrieve the names of defined RADIUS servers and information about the defined CA connectors (but not the sensitive configuration). Fixes #1749
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
+ Coverage 97.05% 97.05% +<.01%
==========================================
Files 149 149
Lines 18114 18115 +1
==========================================
+ Hits 17580 17581 +1
Misses 534 534
Continue to review full report at Codecov.
|
cornelinux
reviewed
Aug 14, 2019
cornelinux
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds endpoints
/system/names/{caconnector,radius}which are accessible for users and admins with the respectiveenrollCERTIFICATE/enrollRADIUSrights. These are now used to retrieve the CA connectors and RADIUS servers during enrollment of CERTIFICATE and RADIUS tokens.As a consequence, the
/radius/and/caconnector/endpoints are not accessible for users anymore.Likewise, the
/privacyideaserver/endpoints are not accessible to users anymore, because REMOTE tokens cannot be enrolled by users anyway.This PR also fixes the enrollment of CERTIFICATE tokens: Without this PR, users cannot choose a certificate template.
Closes #1749