Auto fill vasco serial from digipass blob in admin-ui #910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=========================================
+ Coverage 95.38% 95.4% +0.01%
=========================================
Files 129 129
Lines 15933 15933
=========================================
+ Hits 15198 15201 +3
+ Misses 735 732 -3
Continue to review full report at Codecov.
|
|
Thanks a lot for the pull request. I thought i would push this into the server, so that the basic configuration can decide, if the new token should have the vasco serial number or a generated serial number. But presenting the vasco serial number to the admin is nice anyways! As mentioned, I am a bit hesitant to have the client/webui decide for the serial number. |
|
I was thinking about it this way, if another client other then the webui doesn't supply the serial number it would still get generated as VASC$RANDOM$. But a server generation of serialnumbers for vasco might be a better approach. I will leave that up to you. Could there in theory be a serialno clashing with other type of tokens then vasco? |
|
privacyIDEA generates serial numbers that do not clash - unless you may have over 100.000 tokens and create tokens in a very fast manner (I think there is an issue somewhere - but imho even this should not happen). The serial numbers that are generated by privacyIDEA are prefixed with a token type. However, if you import tokens and the serial number of the imported tokens is simply 2120934980192 (a number), then one imported token would overwrite another imported token. But this also usually does not happen, since in setups mostly one token vendor is used and also the tokenvendors I know, use different number ranges. So short: No. |
@cornelinux i made this for #909
Do you think this is an acceptable solution?
95.79% <0%> (+2.52%)Continue to review full report at Codecov.
I thought i would push this into the server, so that the basic configuration can decide, if the new token should have the vasco serial number or a generated serial number.
But presenting the vasco serial number to the admin is nice anyways!
As mentioned, I am a bit hesitant to have the client/webui decide for the serial number.
But a server generation of serialnumbers for vasco might be a better approach. I will leave that up to you.
Could there in theory be a serialno clashing with other type of tokens then vasco?
The serial numbers that are generated by privacyIDEA are prefixed with a token type.
However, if you import tokens and the serial number of the imported tokens is simply 2120934980192 (a number), then one imported token would overwrite another imported token. But this also usually does not happen, since in setups mostly one token vendor is used and also the tokenvendors I know, use different number ranges.
So short: No.