Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitizers are broken #837

Closed
akoshelev opened this issue Nov 6, 2023 · 2 comments · Fixed by #842
Closed

Sanitizers are broken #837

akoshelev opened this issue Nov 6, 2023 · 2 comments · Fixed by #842

Comments

@akoshelev
Copy link
Collaborator

https://github.com/private-attribution/ipa/actions/runs/6768037077/job/18391702753

Looks like new nightly compiler needs help asserting that things are Send
@akoshelev akoshelev mentioned this issue Nov 6, 2023
Merged
@akoshelev
Copy link
Collaborator Author

works on rustc 1.75.0-nightly (1c05d50c8 2023-10-21)

does not work on rustc 1.75.0-nightly (fee5518cd 2023-11-05)

@akoshelev
Copy link
Collaborator Author

Looks like it is related to rust-lang/rust#117602 and will be fixed in rust-lang/rust#117542

GIven that, I am going to temporarily disable sanitizer actions and enable them again after this issue is fixed on the rustc side

akoshelev added a commit that referenced this issue Nov 6, 2023
@akoshelev
Temporarily disable sanitizers in GH workflow
cf7c7bc 
See #837 for details
@akoshelev akoshelev mentioned this issue Nov 6, 2023
Merged
akoshelev added a commit that referenced this issue Nov 6, 2023
@akoshelev
Temporarily disable sanitizers in GH workflow
4d4dbb1 
See #837 for details
akoshelev added a commit to akoshelev/raw-ipa that referenced this issue Nov 10, 2023
@akoshelev
Enable sanitizers again
8bf0af2 
Fixes private-attribution#837 because the underlying issue rust-lang/rust#117542 is fixed
@akoshelev akoshelev mentioned this issue Nov 10, 2023
Merged
akoshelev added a commit that referenced this issue Nov 17, 2023
@akoshelev
Enable sanitizers again
0e35f73 
Fixes #837 because the underlying issue rust-lang/rust#117542 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable sanitizers again akoshelev/raw-ipa
1 participant
@akoshelev