Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` #117542

compiler-errors · 2023-11-03T14:34:41Z

Only use the normalize_param_env when normalizing the item bound predicate in check_item_bounds, instead of using it when processing this obligation as well. This causes #117606 to reoccur, but hopefully with better caching in the future, we can fix this without having such bad effects on perf.

This PR also fixes #117598. It turns out that the GAT predicate that we install is actually wrong -- given code like:

impl<'r> HasValueRef<'r> for Any {
    type Database = Any;
}

We currently generate a predicate that looks like <Any as HasValueRef<'r>>::Database = Any, where 'r is an early-bound variable. Really this GAT assumption should be universally quantified over the impl's args, i.e. for<'r> <Any as HasValueRef<'r>>::Database = Any, but then we'd need the binder to also include all the WC of the impl as well, which we don't support yet, lol.

compiler-errors · 2023-11-03T14:35:07Z

@bors try @rust-timer queue

cc #117131 (comment)

bors · 2023-11-03T14:36:17Z

⌛ Trying commit 66a1d57 with merge 950874d...

…cate, r=<try> Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` r? `@ghost`

bors · 2023-11-03T15:58:47Z

☀️ Try build successful - checks-actions
Build commit: 950874d (950874d8c4bc441630d6dc485be7b87f9c3d97e4)

rust-timer · 2023-11-03T17:23:28Z

Finished benchmarking commit (950874d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.3%, 1.7%]	5
Improvements ✅ (primary)	-17.7%	[-50.0%, -0.2%]	21
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-17.7%	[-50.0%, -0.2%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-12.8%	[-19.0%, -2.8%]	14
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.4%]	3
All ❌✅ (primary)	-11.8%	[-19.0%, 1.5%]	15

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[2.4%, 4.4%]	5
Improvements ✅ (primary)	-27.5%	[-50.9%, -7.1%]	13
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-27.5%	[-50.9%, -7.1%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 637.051s -> 637.852s (0.13%)
Artifact size: 304.48 MiB -> 304.51 MiB (0.01%)

compiler-errors · 2023-11-05T10:51:55Z

r? lcnr

lcnr · 2023-11-07T08:08:56Z

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

@@ -2217,8 +2217,11 @@ pub(super) fn check_type_bounds<'tcx>(
        .collect();
    debug!("check_type_bounds: item_bounds={:?}", obligations);

+    // Normalize predicates with the assumption


can you add a fixme that we should use this param_env everywhere, but can't due to perf, referencing this PR? At least that's my understanding here?

r=me afterwards

Only instantiate binder during dyn's built-in trait candidate probe once See UI test for demonstration of the issue. This was "caused" by rust-lang#117131, but only because we're using the `normalize_param_env` (which has been augmented with a projection clause used to normalize GATs) which features non-lifetime bound vars in it. Fixes rust-lang#117602 technically, though that's also fixed by rust-lang#117542. r? types

…_bounds

compiler-errors · 2023-11-08T02:35:46Z

@bors r=lcnr

bors · 2023-11-08T02:35:48Z

📌 Commit 97c9d8f has been approved by lcnr

It is now in the queue for this repository.

bors · 2023-11-08T10:08:47Z

⌛ Testing commit 97c9d8f with merge fab1054...

bors · 2023-11-08T12:04:57Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing fab1054 to master...

rust-timer · 2023-11-08T14:12:28Z

Finished benchmarking commit (fab1054): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	1.4%	[0.8%, 2.3%]	12
Improvements ✅ (primary)	-18.4%	[-49.6%, -0.2%]	20
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-17.5%	[-49.6%, 0.4%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 4.5%]	6
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-10.7%	[-20.4%, -0.5%]	17
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-7.5%	[-20.4%, 4.5%]	23

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	3.7%	[3.5%, 3.9%]	3
Improvements ✅ (primary)	-25.3%	[-50.9%, -0.5%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-23.5%	[-50.9%, 0.5%]	15

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 664.216s -> 664.739s (0.08%)
Artifact size: 308.79 MiB -> 308.70 MiB (-0.03%)

nnethercote · 2023-11-08T20:12:29Z

Amazing improvements for bitmaps-3.1.0! And the perf wins outweigh the losses in general.

@rustbot label: +perf-regression-triaged

lqd · 2023-11-08T20:18:02Z

(Note: the wins are fixing #117131 (comment))

compiler-errors · 2023-11-08T20:22:24Z

Yeah sorry y'all, this PR simplify fixes a regression both in behavior and perf.

Fixes private-attribution#837 because the underlying issue rust-lang/rust#117542 is fixed

Fixes #837 because the underlying issue rust-lang/rust#117542 is fixed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2023

Auto merge of rust-lang#117542 - compiler-errors:only-normalize-predi…

950874d

…cate, r=<try> Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 3, 2023

compiler-errors mentioned this pull request Nov 5, 2023

Failure to assume GAT normalization holds when proving GAT bounds in impl #117606

Open

rust-cloud-vms bot force-pushed the only-normalize-predicate branch from 66a1d57 to 3560271 Compare November 5, 2023 10:50

compiler-errors marked this pull request as ready for review November 5, 2023 10:51

rustbot assigned lcnr Nov 5, 2023

lqd mentioned this pull request Nov 5, 2023

Nightly 65e297d1e 2023-11-03 fails to infer auto traits #117602

Closed

This comment has been minimized.

Sign in to view

compiler-errors mentioned this pull request Nov 5, 2023

Only instantiate binder during dyn's built-in trait candidate probe once #117610

Merged

rust-cloud-vms bot force-pushed the only-normalize-predicate branch from 3560271 to cd37539 Compare November 6, 2023 04:17

akoshelev mentioned this pull request Nov 6, 2023

Sanitizers are broken private-attribution/ipa#837

Closed

lcnr reviewed Nov 7, 2023

View reviewed changes

lqd mentioned this pull request Nov 7, 2023

New "lifetime bound not satisfied" error on associated type #117664

Closed

pnkfelix mentioned this pull request Nov 7, 2023

Add all RPITITs when augmenting param-env with GAT bounds in check_type_bounds #117131

Merged

likebreath mentioned this pull request Nov 8, 2023

docs: Add documentations for MSHV and related features cloud-hypervisor/cloud-hypervisor#5919

Merged

Only use normalize_param_env when normalizing predicate in check_item…

97c9d8f

…_bounds

rust-cloud-vms bot force-pushed the only-normalize-predicate branch from cd37539 to 97c9d8f Compare November 8, 2023 02:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2023

rakshith-ravi mentioned this pull request Nov 8, 2023

Rollup of 4 pull requests #117692

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2023

bors merged commit fab1054 into rust-lang:master Nov 8, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Nov 8, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 8, 2023

compiler-errors deleted the only-normalize-predicate branch November 8, 2023 20:22

akoshelev added a commit to akoshelev/raw-ipa that referenced this pull request Nov 10, 2023

Enable sanitizers again

8bf0af2

Fixes private-attribution#837 because the underlying issue rust-lang/rust#117542 is fixed

akoshelev mentioned this pull request Nov 10, 2023

Enable sanitizers again private-attribution/ipa#842

Merged

akoshelev added a commit to private-attribution/ipa that referenced this pull request Nov 17, 2023

Enable sanitizers again

0e35f73

Fixes #837 because the underlying issue rust-lang/rust#117542 is fixed

compiler-errors mentioned this pull request Apr 21, 2024

fix normalizing in different ParamEnvs with the same InferCtxt #124203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` #117542

Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` #117542

compiler-errors commented Nov 3, 2023 •

edited

compiler-errors commented Nov 3, 2023

This comment has been minimized.

bors commented Nov 3, 2023

bors commented Nov 3, 2023

This comment has been minimized.

rust-timer commented Nov 3, 2023

compiler-errors commented Nov 5, 2023

This comment has been minimized.

lcnr Nov 7, 2023

compiler-errors commented Nov 8, 2023

bors commented Nov 8, 2023

bors commented Nov 8, 2023

bors commented Nov 8, 2023

rust-timer commented Nov 8, 2023

nnethercote commented Nov 8, 2023

lqd commented Nov 8, 2023

compiler-errors commented Nov 8, 2023

Only use normalize_param_env when normalizing predicate in check_item_bounds #117542

Only use normalize_param_env when normalizing predicate in check_item_bounds #117542

Conversation

compiler-errors commented Nov 3, 2023 • edited

compiler-errors commented Nov 3, 2023

This comment has been minimized.

bors commented Nov 3, 2023

bors commented Nov 3, 2023

This comment has been minimized.

rust-timer commented Nov 3, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

compiler-errors commented Nov 5, 2023

This comment has been minimized.

Choose a reason for hiding this comment

compiler-errors commented Nov 8, 2023

bors commented Nov 8, 2023

bors commented Nov 8, 2023

bors commented Nov 8, 2023

rust-timer commented Nov 8, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

nnethercote commented Nov 8, 2023

lqd commented Nov 8, 2023

compiler-errors commented Nov 8, 2023

Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` #117542

Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` #117542

compiler-errors commented Nov 3, 2023 •

edited