Only use normalize_param_env when normalizing predicate in check_item_bounds

[compiler-errors]

Only use the normalize_param_env when normalizing the item bound predicate in check_item_bounds, instead of using it when processing this obligation as well. This causes #117606 to reoccur, but hopefully with better caching in the future, we can fix this without having such bad effects on perf.

This PR also fixes #117598. It turns out that the GAT predicate that we install is actually wrong -- given code like:

impl<'r> HasValueRef<'r> for Any {
    type Database = Any;
}

We currently generate a predicate that looks like <Any as HasValueRef<'r>>::Database = Any, where 'r is an early-bound variable. Really this GAT assumption should be universally quantified over the impl's args, i.e. for<'r> <Any as HasValueRef<'r>>::Database = Any, but then we'd need the binder to also include all the WC of the impl as well, which we don't support yet, lol.

[compiler-errors]

@bors try @rust-timer queue

cc #117131 (comment)

[bors]

⌛ Trying commit 66a1d57 with merge 950874d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 950874d (950874d8c4bc441630d6dc485be7b87f9c3d97e4)

[rust-timer]

Finished benchmarking commit (950874d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.3%, 1.7%]	5
Improvements ✅ (primary)	-17.7%	[-50.0%, -0.2%]	21
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-17.7%	[-50.0%, -0.2%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-12.8%	[-19.0%, -2.8%]	14
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.4%]	3
All ❌✅ (primary)	-11.8%	[-19.0%, 1.5%]	15

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[2.4%, 4.4%]	5
Improvements ✅ (primary)	-27.5%	[-50.9%, -7.1%]	13
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-27.5%	[-50.9%, -7.1%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 637.051s -> 637.852s (0.13%)
Artifact size: 304.48 MiB -> 304.51 MiB (0.01%)

[compiler-errors]

r? lcnr

[lcnr]

can you add a fixme that we should use this param_env everywhere, but can't due to perf, referencing this PR? At least that's my understanding here?

r=me afterwards

[compiler-errors]

@bors r=lcnr

[bors]

📌 Commit 97c9d8f has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 97c9d8f with merge fab1054...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing fab1054 to master...

[rust-timer]

Finished benchmarking commit (fab1054): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	1.4%	[0.8%, 2.3%]	12
Improvements ✅ (primary)	-18.4%	[-49.6%, -0.2%]	20
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-17.5%	[-49.6%, 0.4%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 4.5%]	6
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-10.7%	[-20.4%, -0.5%]	17
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-7.5%	[-20.4%, 4.5%]	23

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	3.7%	[3.5%, 3.9%]	3
Improvements ✅ (primary)	-25.3%	[-50.9%, -0.5%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-23.5%	[-50.9%, 0.5%]	15

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 664.216s -> 664.739s (0.08%)
Artifact size: 308.79 MiB -> 308.70 MiB (-0.03%)

[nnethercote]

Amazing improvements for bitmaps-3.1.0! And the perf wins outweigh the losses in general.

@rustbot label: +perf-regression-triaged

[lqd]

(Note: the wins are fixing #117131 (comment))

[compiler-errors]

Yeah sorry y'all, this PR simplify fixes a regression both in behavior and perf.