fix: Fix the problem that esbuild service cannot be detected due to childcompiler in webpack #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hildcompiler in webpack For example, mini CSS extract plugin Among the common plugins in webpack, many plugins create child-compiler to build their own chunks. However, the value of $esbuildservice is not correctly assigned, which causes errors in the compilation of webpack on the child-compiler,For example, mini CSS extract plugin Closes privatenumber#16
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Was there reproduction for a case where this is demonstrated to be needed? Based on the docs here, it sounds like it shouldn't be necessary because child compilers copy plugins from the parent. On a separate note, it might be worth accessing the service via closure so multiple webpack builds running in the same process can access the same instance of esbuild. |
|
#16
repo:
https://github.com/zhusjfaker/esbuild-demo
branch:
master
command:
npm run csr
if u don't Assign an esbuild instance to the child-compiler and run min CSS plugin. You will find the following error
…------------------ 原始邮件 ------------------
发件人: "egoist/esbuild-loader" <notifications@github.com>;
发送时间: 2020年8月6日(星期四) 凌晨0:53
收件人: "egoist/esbuild-loader"<esbuild-loader@noreply.github.com>;
抄送: "zsjax"<439453290@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [egoist/esbuild-loader] fix: Fix the problem that esbuild service cannot be detected due to childcompiler in webpack (#17)
Was there reproduction for a case where this is demonstrated to be needed?
Based on the docs here, it sounds like it shouldn't be necessary because child compilers copy plugins from the parent.
On a separate note, it might be worth accessing the service via closure so multiple webpack builds running in the same process can access the same instance of esbuild.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Let's add a test case next time. Because of how many points of failure that repo has, it's not proven the bug is rooted there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix the problem that esbuild service cannot be detected due to childcompiler in webpack
Among the common plugins in webpack, many plugins create child-compiler to build their own chunks.
However, the value of $esbuildservice is not correctly assigned, which causes errors in the
compilation of webpack on the child-compiler,For example, mini CSS extract plugin
Closes #16