fix: conditional require to not have side effects (#4)

package.json

@@ -55,7 +55,7 @@
 	},
 	"dependencies": {
 		"@rollup/plugin-alias": "^3.1.9",
-		"@rollup/plugin-commonjs": "^21.1.0",
+		"@rollup/plugin-commonjs": "^22.0.0",
 		"@rollup/plugin-inject": "^4.0.4",
 		"@rollup/plugin-json": "^4.1.0",
 		"@rollup/plugin-node-resolve": "^13.2.1",

src/utils/get-rollup-configs.ts

@@ -26,6 +26,8 @@ type EnvObject = {
 	[key: string]: string;
 };
 
+const stripQuery = (url: string) => url.split('?')[0];
+
 const getConfig = {
 	async type(
 		options: Options,
@@ -85,7 +87,9 @@ const getConfig = {
 						})]
 						: []
 				),
-				commonjs(),
+				commonjs({
+					strictRequires: true,
+				}),
 				json(),
 				esbuildTransform(esbuildConfig),
 				createRequire(),
@@ -154,7 +158,7 @@ export async function getRollupConfigs(
 				 * - test tmpdir is a symlink: /var/ -> /private/var/
 				*/
 				entryFileNames: chunk => (
-					fs.realpathSync.native(chunk.facadeModuleId!)
+					fs.realpathSync.native(stripQuery(chunk.facadeModuleId!))
 						.slice(sourceDirectoryPath.length)
 						.replace(/\.\w+$/, extension)
 				),
@@ -197,7 +201,7 @@ export async function getRollupConfigs(
 				 * - test tmpdir is a symlink: /var/ -> /private/var/
 				 */
 				entryFileNames: chunk => (
-					fs.realpathSync.native(chunk.facadeModuleId!)
+					fs.realpathSync.native(stripQuery(chunk.facadeModuleId!))
 						.slice(sourceDirectoryPath.length)
 						.replace(/\.\w+$/, extension)
 				),

tests/fixture-package/src/cjs.cjs

@@ -1,3 +1,5 @@
+console.log('side effect');
+
 module.exports = function sayHello(name) {
 	console.log('Hello', name);
 };

tests/fixture-package/src/conditional-require.js

@@ -1,6 +1,6 @@
 if (process.env.NODE_ENV === 'production') {
 	console.log('production');
-	require('./target');
+	require('./cjs.cjs');
 } else {
 	console.log('development');
 }

tests/specs/builds/output-module.ts

@@ -72,7 +72,7 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(pkgrollProcess.stderr).toBe('');
 
 			const content = await fixture.readFile('dist/cjs.mjs', 'utf8');
-			expect(content).toMatch('export { cjs as default }');
+			expect(content).toMatch('export { cjsExports as default }');
 
 			await fixture.cleanup();
 		});
@@ -98,5 +98,23 @@ export default testSuite(({ describe }, nodePath: string) => {
 
 			await fixture.cleanup();
 		});
+
+		test('conditional require() no side-effects', async () => {
+			const fixture = await createFixture('./tests/fixture-package');
+
+			await fixture.writeJson('package.json', {
+				main: './dist/conditional-require.mjs',
+			});
+
+			const pkgrollProcess = await pkgroll([], { cwd: fixture.path, nodePath });
+
+			expect(pkgrollProcess.exitCode).toBe(0);
+			expect(pkgrollProcess.stderr).toBe('');
+
+			const content = await fixture.readFile('dist/conditional-require.mjs', 'utf8');
+			expect(content).toMatch('\tconsole.log(\'side effect\');');
+
+			await fixture.cleanup();
+		});
 	});
 });