feat(cjs): allow query in import specifier (#366)

privatenumber · Nov 9, 2023 · b32b135 · b32b135
1 parent ddf6fcc
commit b32b135
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/cjs/index.ts b/src/cjs/index.ts
@@ -127,6 +127,12 @@ Object.defineProperty(extensions, '.mjs', {
 
 const defaultResolveFilename = Module._resolveFilename.bind(Module);
 Module._resolveFilename = (request, parent, isMain, options) => {
+	// Strip query string
+	const queryIndex = request.indexOf('?');
+	if (queryIndex !== -1) {
+		request = request.slice(0, queryIndex);
+	}
+
 	if (
 		tsconfigPathsMatcher
 

diff --git a/tests/specs/smoke.ts b/tests/specs/smoke.ts
@@ -341,7 +341,7 @@ export default testSuite(async ({ describe }, { tsx }: NodeApis) => {
 
 						// .js
 						import * as js from './js/index.js';
-						// import * as js from './js/index.js?query=123'; Support query
+						import './js/index.js?query=123';
 						import './js/index';
 						import './js/';
 
@@ -463,7 +463,7 @@ export default testSuite(async ({ describe }, { tsx }: NodeApis) => {
 
 						// .js
 						import * as js from './js/index.js';
-						// import * as js from './js/index.js?query=123'; TODO: Support query
+						import './js/index.js?query=123';
 						import './js/index';
 						import './js/';