Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lock-threads): fix yaml syntax #443

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jbergstroem
Copy link
Contributor

The current syntax for the lock threads job is incorrect. This PR addresses it.

Also, add actionlint to check job syntax as part of the PR workflow.
Finally, format syntax as suggested by actionlint.

Refs: #441

@privatenumber
Copy link
Owner

Was there anything actually broken that this fixes?

@jbergstroem
Copy link
Contributor Author

jbergstroem commented Dec 19, 2023

Was there anything actually broken that this fixes?

yes, the thread job is broken: https://github.com/privatenumber/tsx/actions/workflows/lock-threads.yml

Actionlint output:

$ actionlint .github/workflows/lock-threads.yml
.github/workflows/lock-threads.yml:9:3: "steps" section is missing in job "lock" [syntax-check]
  |
9 |   lock:
  |   ^~~~~
.github/workflows/lock-threads.yml:18:9: "steps" section must be sequence node but got mapping node with "!!map" tag [syntax-check]
   |
18 |         uses: dessant/lock-threads@v5
   |         ^~~~~

Edit: can rip out the actionlint job if you want.

@privatenumber
Copy link
Owner

Gotcha! It looks like I accidentally broke it by removing the - in the last commit, after confirming it to work: https://github.com/privatenumber/tsx/pull/441/files

I appreciate the pull request, but I'm thinking adding another workflow just to check my workflows might be a bit much since it spawns a whole OS just to validate YAML files. Would you mind removing the actionlint part and any changes that aren't related to fixing the issue?

I'll look into linting YAML files using ESLint.

@jbergstroem
Copy link
Contributor Author

Gotcha! It looks like I accidentally broke it by removing the - in the last commit, after confirming it to work: #441 (files)

I appreciate the pull request, but I'm thinking adding another workflow just to check my workflows might be a bit much since it spawns a whole OS just to validate YAML files. Would you mind removing the actionlint part and any changes that aren't related to fixing the issue?

I'll look into linting YAML files using ESLint.

All good; reverted to minimal changes.

@privatenumber privatenumber changed the title fix: add step name for lock job ci(lock-threads): fix yaml syntax Dec 19, 2023
@privatenumber privatenumber merged commit 8c77891 into privatenumber:develop Dec 19, 2023
@jbergstroem jbergstroem deleted the fix/step-name branch December 19, 2023 15:40
@privatenumber
Copy link
Owner

🎉 This issue has been resolved in v4.7.0

If you appreciate this project, please consider supporting this project by sponsoring ❤️ 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants