Merge pull request #204 from prkumar/v0.9.2/pass-through-converter

Update fallback strategies for converters

tests/unit/test_converters.py

@@ -37,17 +37,6 @@ def test_convert_with_caster(self, mocker):
         assert return_value == 3
 
 
-class TestRequestBodyConverter(object):
-    def test_convert_str(self):
-        converter_ = standard.RequestBodyConverter()
-        assert converter_.convert("example") == "example"
-
-    def test_convert_obj(self):
-        converter_ = standard.RequestBodyConverter()
-        example = {"hello": "2"}
-        assert converter_.convert(example) == example
-
-
 class TestStringConverter(object):
     def test_convert(self):
         converter_ = standard.StringConverter()
@@ -63,9 +52,6 @@ def test_create_response_body_converter(self, converter_mock):
         converter = factory.create_response_body_converter(converter_mock)
         assert converter is converter_mock
 
-        # Run & Verify: Otherwise, return None
-        assert None is factory.create_response_body_converter("converter")
-
 
 class TestConverterFactoryRegistry(object):
     backend = converters.ConverterFactoryRegistry._converter_factory_registry

uplink/arguments.py

@@ -179,7 +179,8 @@ def converter_key(self):  # pragma: no cover
     def modify_request(self, request_builder, value):
         argument_type, converter_key = self.type, self.converter_key
         converter = request_builder.get_converter(converter_key, argument_type)
-        self._modify_request(request_builder, converter(value))
+        converted_value = converter(value) if converter else value
+        self._modify_request(request_builder, converted_value)
 
 
 class TypedArgument(ArgumentAnnotation):

uplink/converters/standard.py

@@ -1,6 +1,3 @@
-# Standard library imports
-import json
-
 # Local imports
 from uplink.converters import interfaces, register_default_converter_factory
 
@@ -19,18 +16,6 @@ def convert(self, value):
         return self._converter(value)
 
 
-class RequestBodyConverter(interfaces.Converter):
-    @staticmethod
-    def _default_json_dumper(obj):
-        return obj.__dict__  # pragma: no cover
-
-    def convert(self, value):
-        if isinstance(value, str):
-            return value
-        dumped = json.dumps(value, default=self._default_json_dumper)
-        return json.loads(dumped)
-
-
 class StringConverter(interfaces.Converter):
     def convert(self, value):
         return str(value)
@@ -44,12 +29,13 @@ class StandardConverter(interfaces.Factory):
     converters could handle a particular type.
     """
 
-    def create_response_body_converter(self, type_, *args, **kwargs):
-        if isinstance(type_, interfaces.Converter):
-            return type_
+    @staticmethod
+    def pass_through_converter(type_, *args, **kwargs):
+        return type_
 
-    def create_request_body_converter(self, type_, *args, **kwargs):
-        return Cast(type_, RequestBodyConverter())  # pragma: no cover
+    create_response_body_converter = (
+        create_request_body_converter
+    ) = pass_through_converter
 
     def create_string_converter(self, type_, *args, **kwargs):
         return Cast(type_, StringConverter())  # pragma: no cover