Update fallback strategies for converters #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 44 44
Lines 2398 2390 -8
Branches 176 174 -2
==========================================
- Hits 2396 2388 -8
Misses 2 2
Continue to review full report at Codecov.
|
Merged
prkumar
added a commit
that referenced
this pull request
Feb 7, 2021
In v0.9.3, the `StandardCoverter.create_response_body_converter` was changed to a pass-through converter: i.e., the method would simply return the given type as the response converter. This can cause unintended behavior in the case when the consumer method has a return annotation that is not handled by any registered converters. In this case, the converter chain will invoke the standard coverter's behavior, and try to convert the runtime response by invoking the annotated type's constructor. This can cause failures that are difficult to debug for end users, such as talkpython/100daysofcode-with-python-course#53. This regression was introduced in 89c43d1 (#204).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183, #180.