Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fox for issue #38 #49

Merged
merged 3 commits into from
Apr 6, 2012
Merged

fox for issue #38 #49

merged 3 commits into from
Apr 6, 2012

Conversation

zbyhoo
Copy link
Contributor

@zbyhoo zbyhoo commented Apr 6, 2012

This fix makes possible to close wax with wax_end() and during same application runtime execute again wax_start().

Modifications:

  1. stoping wax_gc during wax_end() by invalidating wax_gc timer
  2. not throwing an error when objc class already exists
  3. zeroing lua_State variable during wax_end()

@probablycorey
Copy link
Owner

Awesome ⭐ 📣

probablycorey pushed a commit that referenced this pull request Apr 6, 2012
@probablycorey probablycorey merged commit bba4229 into probablycorey:master Apr 6, 2012
@zbyhoo
Copy link
Contributor Author

zbyhoo commented Apr 6, 2012

One more thing. I had problems running my compiled version of the Framework project (error saying about bad header in precompiled stdlib file or something like that). The only solution I found was disabling compile-stdlib.sh script . By mistake I pushed that commit to my forked wax repository. I see that this commit was also included in pull request (but I send pull request earlier, I don't know github that much).

I don't know if it's big issue, but probably the project file should be reverted, it's up to you. I'm really sorry for the problem.

Besides that, do you know why this error occured while I was running my compiled version of the Framework project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants