New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster scraping of player seasons stats - fbref. #85
Conversation
…ues are requested. Added some type checks for the stats_type argument.
read_player_season_stats is failing the checks as the logic is too complex. I have added conditional statements to change the url and read_html when using the big 5 leagues data. I am not sure what to do, as breaking up the method would likely replicate code. |
…into andrewRowlinson-big5
One remaining issue is that the table headers are not always consistent between the Big5 leagues and individual leagues, which is annoying if you want to merge tables. For example, GA and PKA has no category in the 2020/21 Ligue 1, but is grouped under Goals in the Big 5 leagues. |
Thanks for working on this. I really want to use this for my project, but it takes too long scraping each of the leagues individually currently. |
I am having another go at this [previous attempt #69] because you have updated the FBRef class to use the league pages. I have tried this against all stat_types for 2020-2021 and it seems to work
I am not able to run the tests locally, but I'll try to fix anything that doesn't work after.