-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons in /usr/share/icons/hicolor/256x256/ don't seem to work #50
Comments
My suggestion to fix this would simply to set the |
Each AppDir, including the one inside an AppImage, needs to have a I will have a look at the logic flaws you are pointing out later. Reference: |
Say you have |
In that case I think there's another bug in the code as the check at go-appimage/src/appimagetool/appimagetool.go Line 369 in f1ebcce
doesn't check in .../256x256/apps but only in .../256x256 ☝️
|
Good catch 👍 |
If I read the code correctly, then the code looks for the presence of the icon specified in the desktop file in
appdir + /usr/share/icons/hicolor/256x256/
here:go-appimage/src/appimagetool/appimagetool.go
Lines 369 to 382 in f1ebcce
What strikes me though is that in the first check it is checked whether the icon exists at the root of the appdir. This in and of itself is not what I find interesting. Rather the fact that this code part sets the
iconFile
variable:go-appimage/src/appimagetool/appimagetool.go
Lines 367 to 369 in f1ebcce
The second check however doesn't seem to set this variable. Thus
go-appimage/src/appimagetool/appimagetool.go
Line 386 in f1ebcce
Prints
aka: An empty String.
A few lines down however this variable is used to assemble a path to copy:
go-appimage/src/appimagetool/appimagetool.go
Line 397 in f1ebcce
In my case this results in this error:
I also think it is interesting that the code above seems to create a
.DirIcon
file in the AppImage's rootgo-appimage/src/appimagetool/appimagetool.go
Lines 371 to 381 in f1ebcce
and a bit further down we have
go-appimage/src/appimagetool/appimagetool.go
Lines 391 to 394 in f1ebcce
which seems to exactly cancel above action. Interestingly however I did not see the
Deleting pre-existing .DirIcon
message in my logs so maybe I am missing something here 🤔All in all I think that maybe the functionality for icons in the respective subdir is broken atm...
The text was updated successfully, but these errors were encountered: