Skip to content
This repository has been archived by the owner on Sep 14, 2019. It is now read-only.

Always use the .github folder #16

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Always use the .github folder #16

merged 2 commits into from
Nov 16, 2018

Conversation

hiimbex
Copy link
Contributor

@hiimbex hiimbex commented Jul 19, 2018

Closes #13

After some long discussion with @probot/maintainers, we decided the best course of action would be to simply enforce .github folders in all repos, even the .github repo. This makes sense given GitHub Apps' permissioning system's 'single file' access option:

screen shot 2018-07-19 at 2 05 44 pm

cc/ @cco3 @jan-auer @nesl247 @dessant

@hiimbex hiimbex requested a review from a team July 19, 2018 21:07
@dessant
Copy link

dessant commented Jul 19, 2018

Looks great! Will custom file paths still be allowed?

@hiimbex
Copy link
Contributor Author

hiimbex commented Jul 19, 2018

Will custom file paths still be allowed?

This should not affect custom files paths; however if that path is in a private repo and does not match the single file permissions, it will be inaccessible by an app.

@dessant
Copy link

dessant commented Jul 19, 2018

@hiimbex, yeah, I've been asking because of private repos, custom file paths cause the same issues for hosted apps.

@nesl247
Copy link

nesl247 commented Jul 19, 2018

I don't think there is anything that can be done about custom paths given GH's single file option. Especially since that should be used for hosted apps rather than full read access for security purposes.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes my life easier right now :)

@gr2m
Copy link
Contributor

gr2m commented Nov 7, 2018

Hey can we please get this merged and released, or are there any blockers left?

@gr2m gr2m mentioned this pull request Nov 7, 2018
@hiimbex hiimbex merged commit d819541 into master Nov 16, 2018
@hiimbex hiimbex deleted the use-gh-folder-always branch November 16, 2018 17:39
@cco3
Copy link
Contributor

cco3 commented Nov 16, 2018

Hi! Does this immediately affect other official probot apps that use probot-config, or is there some way I can track its impact?

@hiimbex
Copy link
Contributor Author

hiimbex commented Nov 16, 2018

Because we're using npm versioning, it won't affect any apps requiring probot-config 0.2.0, but when we release a new version (likely 1.0.0), they'll all have to explicitly upgrade to get this behavior change.

@cco3
Copy link
Contributor

cco3 commented Nov 16, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants