Skip to content
This repository has been archived by the owner on Sep 14, 2019. It is now read-only.

Private base repo stop bots from using single file permission #13

Closed
nesl247 opened this issue Jul 12, 2018 · 6 comments
Closed

Private base repo stop bots from using single file permission #13

nesl247 opened this issue Jul 12, 2018 · 6 comments
Assignees
Labels

Comments

@nesl247
Copy link

nesl247 commented Jul 12, 2018

When you have the .github repository, and a bot requires a single file .github/stale.yml, probot-config does not work with the .github directory because it requires the files to be in the root instead of the same path.

This was caused with #6

@dessant
Copy link

dessant commented Jul 12, 2018

The issue also applies to custom file paths, introduced in #8.

@nesl247
Copy link
Author

nesl247 commented Jul 12, 2018

I think the best, at quickest way to resolve this is to either change the current behavior of the root files to be a fallback, or add a fallback to check for the .github directory.

I'm not sure about the issue with the other linked ticket though.

@hiimbex
Copy link
Contributor

hiimbex commented Jul 13, 2018

I think the better solution might just be to require the .github/ folder in the .github repo, no matter what, so the single file permissions can work cleanly.

@nesl247
Copy link
Author

nesl247 commented Jul 13, 2018

@hiimbex I agree. That's what I suggested in #1.

@hiimbex
Copy link
Contributor

hiimbex commented Jul 13, 2018

But the scenario where it can't read from the .github repo file only happens if the .github is private correct?

So maybe it's easier to just specify the .github repo must public? Unless there's another issue with that solution?

@nesl247
Copy link
Author

nesl247 commented Jul 13, 2018

Yes, it only applies to private repositories. The reason it shouldn't require a public repo for a mostly private organization, we don't want anyone submitting PRs against it, we may also have specific settings in there for different bots that shouldn't be viewable outside of the organization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants