Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename _apps to pr-triage.md #194

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Update and rename _apps to pr-triage.md #194

merged 1 commit into from
Jun 25, 2018

Conversation

sotayamashita
Copy link
Contributor

@sotayamashita sotayamashita commented Jun 19, 2018 •
edited
Loading

@request-info
Copy link

request-info bot commented Jun 19, 2018

The maintainers of this repository would appreciate it if you could provide more information.

@sotayamashita
Copy link
Contributor Author

sotayamashita commented Jun 19, 2018 •
edited
Loading

CI fails but I think it has nothing to do with my change. Any idea ?

- _site/apps/ci-reporter/index.html
  *  External link https://github.com/JasonEtco/ci-reporter failed: 404 No error
  *  External link https://github.com/JasonEtco/ci-reporter/issues/new failed: 404 No error
  *  External link https://github.com/JasonEtco/ci-reporter/issues/new?title=%5BConfig%5D&body=Can%20you%20please%20add%20the%20___%20config%20option failed: 404 No error
HTML-Proofer found 3 failures!
The command "./script/cibuild" exited with 1.

hiimbex
hiimbex suggested changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@hiimbex hiimbex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sotayamashita! Thanks for the PR! You're right in that the build breaking is not your fault cough @JasonEtco cough.

I like your app and the graphic a lot! The file you added does need to go in the /_apps/ folder before this can be merged.

hiimbex
hiimbex reviewed Jun 19, 2018
View reviewed changes
pr-triage.md Outdated
@@ -0,0 +1,47 @@
---
# A human-friendly name of your listing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these comments need to be removed for the formatting to work correctly.

@sotayamashita
Update and rename _apps to pr-triage.md
7f52519 
Update pr-triage.md

pr-triage.md -> _apps/pr-triage.md
@sotayamashita
Copy link
Contributor Author

@hiimbex I appreciate your quick review. I fixed some issue. Please review it

hiimbex
hiimbex approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@hiimbex hiimbex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiimbex hiimbex merged commit c99ed2e into probot:master Jun 25, 2018
@sotayamashita sotayamashita deleted the patch-1 branch June 25, 2018 23:19
@sotayamashita sotayamashita mentioned this pull request Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiimbex hiimbex hiimbex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotayamashita @hiimbex