Missing types for other packages used by Probot

[wolfy1339]

Bug Report

Current Behavior
All TypeScript types located in src/@types/ are missing from final build, and any used as they are marked as devDependencies and cause errors when using Probot in a TS application

// Your code here
import { Application } from 'probot';
export = (app: Application) => {
  app.log('There is a bug')
}

Expected behavior/code
For the npm module to have the required types, and the package.json list the @types/* packages in dependencies

Environment

• Probot version(s): [e.g. v6.0.0] any version written in TS
• Node/npm version: [e.g. Node 8/npm 5] Node 10
• OS: [e.g. OSX 10.13.4, Windows 10] Windows 10

Possible Solution
Add a script to copy those files to the final output folder and mark the required @types/* packages as dependencies

Additional context/Screenshots
Encompases #675

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wolfy1339]

Not stale

[gr2m]

Would this be fixed if we add the src/@types folder to

probot/package.json

Lines 20 to 25 in bcc3203

	"files": [
	"lib",
	"bin",
	"static",
	"views"
	],

An alternative would be to list the @types in dependencies with a relative path instead of a version as the value. But I think we’ll have to add package.json files in order to make that work?

[wolfy1339]

Yes, that could work

…

________________________________ From: Gregor Martynus <notifications@github.com> Sent: Thursday, February 14, 2019 4:01:37 PM To: probot/probot Cc: wolfy1339; Author Subject: Re: [probot/probot] Missing types for other packages used by Probot (#759) Would this be fixed if we add the src/@types folder to https://github.com/probot/probot/blob/bcc3203930e47385fb997f247b5a5bf1bc84b6b0/package.json#L20-L25 An alternative would be to list the @types in dependencies with a relative path instead of a version as the value. But I think we’ll have to add package.json files in order to make that work? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#759 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEYfFZB4wlUeWu71Onf3qlCAT4QF5iXzks5vNc6xgaJpZM4YNuAQ>.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wolfy1339]

Not stale

…

________________________________ From: stale[bot] <notifications@github.com> Sent: Monday, April 15, 2019 7:53:59 PM To: probot/probot Cc: wolfy1339; Author Subject: Re: [probot/probot] Missing types for other packages used by Probot (#759) This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#759 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEYfFatK4PYHQ6_ukURSJGCVIBd1tbQlks5vhREXgaJpZM4YNuAQ>.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[luishdz1010]

Any workarounds?

[MaximDevoir]

I was able to reproduce this issue when using Probot@v7 but was unable to reproduce the issue with the latest version of Probot (currently v9).

Thanks to @wolfy1339 and his many contributions, Probot now has much better type information than when this issue was created.

@luishdz1010 I don't think there are any known workarounds at the moment. To get access to the latest type information from Probot, you'll have to migrate Probot to v9 (requires Node 10, see the 7 -> 9 migration guide - we can safely skip Probot 8. For those who are using Probot v6, here's the 6 -> 7 migration guide).

This issue appears to have been fixed with the release of v9. What do you think @wolfy1339?

[KnisterPeter]

Currently (v9.x) we needed to add these typings to our own typings since they are reexported by the types of probot but only devDependencies:

• @types/bunyan
• @types/express
• @types/ioredis

Also: There are no typings for promise-events.

[gr2m]

I think this should all be resolved now. Please let me know if there is anything left