Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Port in use error handling (#767) #1260

Merged
merged 1 commit into from Jul 12, 2020
Merged

fix: Port in use error handling (#767) #1260

merged 1 commit into from Jul 12, 2020

Conversation

FoseFx
Copy link
Contributor

@FoseFx FoseFx commented Jul 11, 2020 •
edited by gr2m

@NikhilM98 opened a PR (#784) in 2018 and it had no activity since Feb 2019. All of the credit goes to @NikhilM98, I just added the missing test

closes #784

@FoseFx FoseFx requested a review from a team as a code owner July 11, 2020 08:53
gr2m
gr2m approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@gr2m gr2m merged commit 1445abe into probot:master Jul 12, 2020
@github-actions
Copy link

🎉 This PR is included in version 9.11.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

gr2m pushed a commit that referenced this pull request Jul 17, 2020
@FoseFx @gr2m
fix: handle "port in use" (#1260)
b0c311b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FoseFx @gr2m