fix: Port in use error handling (#767)

[NikhilM98]

Fixes issue #767

[gr2m]

could we add a test, sth like this?

const http = require('http')
const server = http.createServer((req, res) => {
  res.end()
}).listen(3000, async () => {
  console.log('listening at 3000')

  // run test here

  server.close(() => {
    console.log('server stopped')
  })
})

[JasonEtco]

This is looking good - I left one note, in addition to @gr2m's suggestion!

[NikhilM98]

Thanks, @gr2m for the suggestion. But I'm facing another problem while writing tests. I was trying something like

  describe('initilization', () => {
    it('should expect the correct error if port already in use', async () => {
      const http = require('http')
      const server = http.createServer().listen(3001, async () => {
        const testApp = createProbot({ port: 3001 })
        testApp.logger.error = jest.fn()
        testApp.start( () => {
          expect(testApp.logger.error.mock.calls[0]).toBe('Port:3001 is already in use. You can define the PORT environment variable into use a different port.')
          server.close()
        })
      })
    })
  })

But testApp.start is taking infinite time to proceed. I think I should not have called testApp.start directly. I'd be great if you can give me some advice.

[gr2m]

I don’t know when I’ll have time myself and I’m not as familiar with Probots code base, please give me a few days. Or maybe someone else can beat me to helping you out :)

[NikhilM98]

@JasonEtco I've changed process.exit() to process.exit(1) as requested.
@gr2m I'm still facing issue with calling .start() function in test.js as described here

[gr2m]

@NikhilM98 I don’t know what the problem could be out of my head, I’d need to spend some more time investigating and I don’t have the time right now. Maybe you or someone else finds out what is going on, if not I’ll get back to it eventually, but not anytime soon

[github-actions]

🎉 This issue has been resolved in version 9.11.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀