Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct wrong link to Developing an App page #1572

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

tnorthcutt
Copy link
Contributor

@tnorthcutt tnorthcutt commented Jul 8, 2021

Currently, the link to Developing an App on https://probot.github.io/docs/hello-world/ points to https://probot.github.io/docs/hello-world/development.md which does not exist. This PR fixes that.


View rendered docs/hello-world.md

@tnorthcutt tnorthcutt requested a review from a team as a code owner July 8, 2021 17:13
@welcome
Copy link

welcome bot commented Jul 8, 2021

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@request-info
Copy link

request-info bot commented Jul 8, 2021

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@tnorthcutt tnorthcutt changed the title Correct wrong link to Developing an App page docs: Correct wrong link to Developing an App page Jul 8, 2021
Copy link
Member

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!

Please make sure that your commits are semantic (see the instructions on the failed check), so they should start with docs: too (not only the PR title).

Otherwise, thanks for the fix, this was accidentally introduced when probot.github.io migrated to 11ty!

docs/hello-world.md Outdated Show resolved Hide resolved
Co-authored-by: Aaron Dewes <aaron.dewes@web.de>
@tnorthcutt
Copy link
Contributor Author

@AaronDewes roger that – not sure if there's a good way to retroactively fix the commit message...?

@AaronDewes
Copy link
Member

@AaronDewes roger that – not sure if there's a good way to retroactively fix the commit message...?

Using Git via CLI, you can do that, I can modify your commit for you if you want.

@AaronDewes
Copy link
Member

Seems like the PR is valid, no need to do anything then.

@gr2m
Copy link
Contributor

gr2m commented Jul 8, 2021

Please make sure that your commits are semantic (see the instructions on the failed check), so they should start with docs: too (not only the PR title).

@AaronDewes I wouldn't worry about semantic commits in PRs, we squash & merge in the end any way. No need to bother contributors with it. The Semantic Pull Request App is happy when we change the PR title to a semantic commit, too.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit ef70c58 into probot:master Jul 8, 2021
@welcome
Copy link

welcome bot commented Jul 8, 2021

Thanks for your contribution to probot! 🎉
Congrats!

@tnorthcutt tnorthcutt deleted the patch-1 branch July 8, 2021 20:01
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

🎉 This PR is included in version 12.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants