-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Correct wrong link to Developing an App
page
#1572
Conversation
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details? |
Developing an App
pageDeveloping an App
page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR!
Please make sure that your commits are semantic (see the instructions on the failed check), so they should start with docs:
too (not only the PR title).
Otherwise, thanks for the fix, this was accidentally introduced when probot.github.io migrated to 11ty!
Co-authored-by: Aaron Dewes <aaron.dewes@web.de>
@AaronDewes roger that – not sure if there's a good way to retroactively fix the commit message...? |
Using Git via CLI, you can do that, I can modify your commit for you if you want. |
Seems like the PR is valid, no need to do anything then. |
@AaronDewes I wouldn't worry about semantic commits in PRs, we squash & merge in the end any way. No need to bother contributors with it. The Semantic Pull Request App is happy when we change the PR title to a semantic commit, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 12.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Currently, the link to
Developing an App
on https://probot.github.io/docs/hello-world/ points to https://probot.github.io/docs/hello-world/development.md which does not exist. This PR fixes that.View rendered docs/hello-world.md