-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make probot work with latest octokit deps #1864
Conversation
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
There is some in progress to make tests pass again, see #1855 |
This comment was marked as outdated.
This comment was marked as outdated.
Yes, sure. I'd prefer a Update: there you go https://github.com/probot/probot/tree/beta |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made my remarks. Please take a look :)
|
||
export async function captureLogOutput(action: () => any): Promise<string> { | ||
export async function captureLogOutput( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems odd. Why couldnt we use the old implementation?
How can I support you for reviewing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a first high-level review. Can you update the node version matrix in the test ci?
Addressed your remarks :) |
I think all your remarks are resolved. Just my three remarks at the beginning are left and needs feedback from you guys. @gclhub |
I am quiete satisfied with this PR. I think it is ready for review/merge :) |
@gclhub |
🎉 This PR is included in version 13.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
note:
default webhookPath is now "/api/github/webhooks" and has to be overriden when migrating...
closes #1845, closes #1855, closes #1821