Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable stats #392

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

wilhelmklopp
Copy link
Contributor

@wilhelmklopp wilhelmklopp commented Jan 12, 2018

As discussed in office hours yesterday, the stats plugin isn't very scalable after a certain point.

You can now set the environment variable DISABLE_STATS, and the stats plugin won't load

cc @JasonEtco @bkeepers

@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #392 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   95.03%   95.07%   +0.03%     
==========================================
  Files          18       18              
  Lines         262      264       +2     
  Branches       30       31       +1     
==========================================
+ Hits          249      251       +2     
  Misses         11       11              
  Partials        2        2
Impacted Files Coverage Δ
lib/plugins/stats.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71b2a0...aa3e639. Read the comment docs.

@bkeepers
Copy link
Contributor

cc #380, which this is a temporary workaround for.

@bkeepers bkeepers merged commit dcd0e32 into probot:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants