-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bottleneck to the latest version 馃殌 #397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 19 19
Lines 277 277
Branches 29 29
=======================================
Hits 260 260
Misses 16 16
Partials 1 1 |
Version 2.0.1 just got published. |
https://github.com/probot/scheduler also needs to be updated before this is merged.
|
bkeepers
approved these changes
Jan 26, 2018
@JasonEtco would you have time to resolve conflicts in this now that #400 is merged? I'm happy to do it if you're busy this week, just didn't want to step on toes here. |
Yep no problemo @bkeepers |
bkeepers
added a commit
that referenced
this pull request
Feb 4, 2018
* origin/master: (32 commits) fix(package): Update bottleneck to the latest version 馃殌 (#397) Use npx, document yarn (#417) doc: Add `.env.example` template info (#414) Further explicit note on yml config for target repos (#416) fix(package): update dotenv to version 5.0.0 (#412) Payload object explanation in documentation (#411) More explicit notes on yml config for target repos (#415) fix(package): update @octokit/rest to version 14.0.8 refactor: github -> @octokit/rest chore(console): github is now octokit test: adapt for @octokit/rest fix(package): -github, +@octokit/rest Allow setting logger name to separate components (#355) Improve docs on `probot simulate` command (#405) docs: Add "next" front matter (#406) chore(package): update semantic-release to version 12.2.2 (#395) docs: Add docs for data persistence (#242) Add section on how to help if you're just starting out (#393) Remove unused eventsource, move jest to dev deps (#403) fix: update log when server starts #394 (#398) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0.0 of bottleneck was just published.
The version 2.0.0 is not covered by your current version range.
If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of bottleneck.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
Version 2Bottleneck Version 2
This new version is almost 100% compatible with Version 1 and it adds some powerful features such as:
Upgrading to v2
The internal algorithms essentially haven't changed from v1, but many small changes to the interface were made to introduce new features.
All the breaking changes:
submitPriority()
, usesubmit()
with an options object instead.schedulePriority()
, useschedule()
with an options object instead.rejectOnDrop
option is nowtrue
by default.null
instead of0
to indicate an unlimitedmaxConcurrent
value.null
instead of-1
to indicate an unlimitedhighWater
value.changeSettings()
toupdateSettings()
, it now returns a promise to indicate completion. It takes the same options object as the constructor.nbQueued()
toqueued()
.nbRunning
torunning()
, it now returns its result using a promise.isBlocked()
.changePenalty()
, it is now done through the options object like any other limiter setting.changeReservoir()
, it is now done through the options object like any other limiter setting.stopAll()
. Use thereservoir
feature to disable execution instead.check()
now accepts an optionalweight
argument, and returns its result using a promise.Cluster
feature is now calledGroup
. This is to distinguish it from the new v2 Clustering feature.Group
constructor takes an options object to match the limiter constructor.Group
changeTimeout()
method toupdateSettings()
, it now takes an options object.Version 2 is more user-friendly, powerful and reliable.
Commits
The new version differs by 33 commits.
7c22c90
2.0.0 Updated dep
1aed0a4
2.0.0
49cff2e
Fixed Group autocleanup
7d6cc14
README feedback
bdf0d9f
2.0.0-beta.4
1f59c3c
Typecript typings for v2
7ef79ef
Update beta version
5038ca6
2.0.0-beta.3
4b4954f
2.0.0-beta.2
2044e9d
Readme improvements
ea86d03
Minor readme fixes
e57bed5
v2-beta1 docs update
f772707
2.0.0-beta.1
ff4e5b9
Updated Readme for v2
02db071
Error handling improvements
There are 33 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 馃尨