Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .env.example template info #414

Merged
merged 5 commits into from
Feb 3, 2018
Merged

Add .env.example template info #414

merged 5 commits into from
Feb 3, 2018

Conversation

allthedoll
Copy link
Contributor

This pull request adds a note about the .env.example file that can be used as a template when following Configure a GitHub App to set the WEBHOOK_PROXY_URL.

Original issue: probot/friction#20

@welcome
Copy link

welcome bot commented Feb 1, 2018

Thanks for opening this pull request! Please check out our contributing guidelines.

@bkeepers
Copy link
Contributor

bkeepers commented Feb 1, 2018

Thanks for the PR!

What would you think about updating https://github.com/probot/create-probot-app to copy .env.example to .env?

https://github.com/probot/create-probot-app/blob/master/bin/create-probot-app.js#L122-L130

GitHub
create-probot-app - Create a new probot app
GitHub
create-probot-app - Create a new probot app

@allthedoll
Copy link
Contributor Author

@bkeepers that's an even better idea, so I've rewritten it. What do you think?

@@ -56,7 +56,7 @@ The most important files note here are `index.js`, which is where the code for y

To run your app in development, you will need to configure a GitHub App to deliver webhooks to your local machine.

1. Go to [smee.io](https://smee.io) and click **Start a new channel**. Set `WEBHOOK_PROXY_URL` in your `.env` to the URL that you are redirected to (you can use `.env.example` as a template).
1. Go to [smee.io](https://smee.io) and click **Start a new channel**. On your local, copy `.env.example` to `.env`, then set `WEBHOOK_PROXY_URL` to the URL that you are redirected to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "On your local machine"?

@bkeepers
Copy link
Contributor

bkeepers commented Feb 1, 2018

Sorry, just to clarify, I was suggesting we update create-probot-app to just copy the file for you so it just exists.

@allthedoll
Copy link
Contributor Author

@bkeepers That's fair and an easier way to do it. For further clarity, should we still keep the .env.example or just have it create the .env?

cc @JasonEtco ^

@bkeepers
Copy link
Contributor

bkeepers commented Feb 1, 2018

For further clarity, should we still keep the .env.example or just have it create the .env?

.env is in .gitignore, so I think it should still keep .env.example for other contributors.

Actually now that you bring it up, the doc change here might be the better solution because it works whether you were the person that ran create-probot-app or you cloned a repo from someone else that ran it.

🤔 What do you think?

@bkeepers bkeepers merged commit 0b1a875 into probot:master Feb 3, 2018
@welcome
Copy link

welcome bot commented Feb 3, 2018

Thanks for your contribution to probot! 🎉
Congrats!

@bkeepers
Copy link
Contributor

bkeepers commented Feb 3, 2018

Thanks @allthedoll for this, and sorry for the back and forth. I made a few tweaks and merged it.

bkeepers added a commit that referenced this pull request Feb 4, 2018
* origin/master: (32 commits)
  fix(package): Update bottleneck to the latest version 🚀 (#397)
  Use npx, document yarn (#417)
  doc: Add `.env.example` template info (#414)
  Further explicit note on yml config for target repos (#416)
  fix(package): update dotenv to version 5.0.0 (#412)
  Payload object explanation in documentation (#411)
  More explicit notes on yml config for target repos (#415)
  fix(package): update @octokit/rest to version 14.0.8
  refactor: github -> @octokit/rest
  chore(console): github is now octokit
  test: adapt for @octokit/rest
  fix(package): -github, +@octokit/rest
  Allow setting logger name to separate components (#355)
  Improve docs on `probot simulate` command (#405)
  docs: Add "next" front matter (#406)
  chore(package): update semantic-release to version 12.2.2 (#395)
  docs: Add docs for data persistence (#242)
  Add section on how to help if you're just starting out (#393)
  Remove unused eventsource, move jest to dev deps (#403)
  fix: update log when server starts #394 (#398)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants