Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to @octokit/rest@15.18.0 #768

Merged
merged 2 commits into from
Nov 20, 2018
Merged

update to @octokit/rest@15.18.0 #768

merged 2 commits into from
Nov 20, 2018

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Nov 13, 2018 •
edited
Loading

This should pass once https://github.com/octokit/rest.js/pull/1094 is released. Update: it does :)

@gr2m gr2m requested a review from a team as a code owner November 13, 2018 23:47
@gr2m gr2m changed the title [WIP] update to @octokit/rest@15.17.0 [WIP] update to @octokit/rest@15.18.0 Nov 14, 2018
tcbyrd
tcbyrd approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@tcbyrd tcbyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Actually like the new naming scheme. Just to be clear, the old methods will still work in 15.8.0, but will be removed in 16.0.0?

@gr2m
Copy link
Contributor Author

gr2m commented Nov 20, 2018

Just to be clear, the old methods will still work in 15.8.0, but will be removed in 16.0.0?

Yes 👍

@gr2m gr2m changed the title [WIP] update to @octokit/rest@15.18.0 update to @octokit/rest@15.18.0 Nov 20, 2018
@hiimbex
Copy link
Contributor

hiimbex commented Nov 20, 2018

@gr2m what's your recommendation for the Probot release versioning to match this? Major or minor?

@gr2m
Copy link
Contributor Author

gr2m commented Nov 20, 2018

minor, there are no breaking changes, only deprecations. And for deprecations I think the convention is to bump the minor version number

@JasonEtco
Copy link
Member

Just to be clear, the old methods will still work in 15.8.0, but will be removed in 16.0.0?

Yes 👍

☝️ Glad to hear that! In that case, I'm 👍 for a minor version bump.

@hiimbex
Copy link
Contributor

hiimbex commented Nov 20, 2018

(In my head I thought this was v0.16.0 🤦‍♂️) 👍 to minor! Feel free to merge when ready @gr2m! Let me know if you'd like me to do the release

@gr2m gr2m merged commit 59bf271 into master Nov 20, 2018
@gr2m
Copy link
Contributor Author

gr2m commented Nov 20, 2018

I just set @octokit/rest v16 to latest :) If you could publish a minor that’d be great. We can see how that goes for a little while and then eventually update to v16, which would be a breaking change. Maybe we can ship other pending breaking changes while at it, if there are any?

@hiimbex hiimbex deleted the update-to-octokit-rest-15.17.0 branch November 20, 2018 18:19
@hiimbex
Copy link
Contributor

hiimbex commented Nov 20, 2018 •
edited by unfurl-links bot
Loading

https://github.com/probot/probot/releases/tag/v7.4.0 is live 🎉

GitHub
🤖 A framework for building GitHub Apps to automate and improve your workflow - probot/probot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcbyrd tcbyrd tcbyrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gr2m @hiimbex @JasonEtco @tcbyrd